Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display equivalent odo init command for odo init interactive #6265

Merged

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd anandrkskd@gmail.com

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5465

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

run `odo init` in interactive mode
odo init

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 27, 2022
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit c6c4a13
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6363ce17226bc4000946fdc5
😎 Deploy Preview https://deploy-preview-6265--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Oct 27, 2022

Validate Tests on commit 6ba4dea finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 27, 2022

Unit Tests on commit 6ba4dea finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 27, 2022

Windows Tests (OCP) on commit 6ba4dea finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 27, 2022

Kubernetes Tests on commit 6ba4dea finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 27, 2022

OpenShift Tests on commit 6ba4dea finished successfully.
View logs: TXT HTML

pkg/init/interface.go Outdated Show resolved Hide resolved
pkg/odo/cli/init/init.go Outdated Show resolved Hide resolved
pkg/odo/cli/init/init.go Outdated Show resolved Hide resolved
@feloy
Copy link
Contributor

feloy commented Nov 3, 2022

@anandrkskd could you please rebase this PR?
e2e tests fail on some issue fixed by a PR merged recently

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

Thanks Philippe, rebased the PR.

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Nov 3, 2022

NoCluster Tests on commit 6ba4dea finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Nov 3, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 3, 2022
@feloy
Copy link
Contributor

feloy commented Nov 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 26c1d9b into redhat-developer:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When running interactive odo init command, get the equivalent command with flags
3 participants