Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Devfile personalization in interactive mode from empty directory #6351

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Nov 28, 2022

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this:

/kind bug
What does this PR do / why we need it:

This PR adds the ability to personalization devfile when running odo init in interactive mode from an empty directory

Which issue(s) this PR fixes:

Fixes #6313

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

mkdir /tmp/testodo; cd /tmp/testodo
 odo init
  __
 /  \__     Initializing a new component
 \__/  \    Files: No source code detected, a starter project will be created in the current directory
 /  \__/    odo version: v3.3.0
 \__/

Interactive mode enabled, please answer the following questions:
? Select language: Go
? Select project type: Go Runtime
 ✓  Downloading devfile "go" from registry "DefaultDevfileRegistry" [2s]

↪ Container Configuration "runtime":
  OPEN PORTS:
    - 8080
  ENVIRONMENT VARIABLES:

? Select container for which you want to change configuration? NONE - configuration is correct
? Which starter project do you want to use? go-starter
? Enter component name: test
 ✓  Downloading starter project "go-starter" [733ms]

Port configuration using flag is currently not supported  

You can automate this command by executing:
   odo init --name test --devfile go --devfile-registry DefaultDevfileRegistry --starter go-starter


Your new component 'test' is ready in the current directory.
To start editing your component, use 'odo dev' and open this folder in your favorite IDE.
Changes will be directly reflected on the cluster.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2022
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 9f83f33
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63873d3d1eed13000869f4ac

@openshift-ci
Copy link

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anandrkskd by writing /assign @anandrkskd in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

NoCluster Tests on commit 4ae041d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Unit Tests on commit 4ae041d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Validate Tests on commit 4ae041d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Windows Tests (OCP) on commit 4ae041d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

OpenShift Tests on commit 4ae041d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Kubernetes Tests on commit 4ae041d finished successfully.
View logs: TXT HTML

@anandrkskd anandrkskd closed this Nov 28, 2022
@anandrkskd anandrkskd reopened this Nov 28, 2022
@anandrkskd anandrkskd closed this Nov 28, 2022
@anandrkskd anandrkskd reopened this Nov 28, 2022
@feloy feloy closed this Nov 28, 2022
@feloy feloy reopened this Nov 28, 2022
@valaparthvi
Copy link
Contributor

@rm3l I believe this might slightly affect your work on #5863. I remember we discussed something about port detection when the directory is empty, but I can't recall the exact thing.

run Devfile personilization in interactive mode from empty directory

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@rm3l
Copy link
Member

rm3l commented Nov 30, 2022

@rm3l I believe this might slightly affect your work on #5863. I remember we discussed something about port detection when the directory is empty, but I can't recall the exact thing.

Indeed, we discussed this point. But I think #5863 should not be affected by this PR.
When the directory is empty, the interactive mode of odo init won't be affected by port detection (relevant only where there is source code, or later when running non-interactively with a --port flag, but that's a separate issue).

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 30, 2022
@rm3l rm3l closed this Nov 30, 2022
@rm3l rm3l reopened this Nov 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor

feloy commented Nov 30, 2022

/override ci/prow/v4.11-integration-e2e
Flay e2e test failing
Pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Flay e2e test failing
Pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Nov 30, 2022

/override ci/prow/v4.11-integration-e2e
Infra error
Pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Infra error
Pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3e81c10 into redhat-developer:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo init interactive mode does not prompt for Devfile personalization when running from empty directory
5 participants