Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Github Actions for podman testing #6385

Merged
merged 9 commits into from
Jan 5, 2023
Merged

Adding Github Actions for podman testing #6385

merged 9 commits into from
Jan 5, 2023

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Dec 7, 2022 •
edited
Loading

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this:

/kind tests

What does this PR do / why we need it:
This PR Adds GitHub Actions to tests odo against podman.

Which issue(s) this PR fixes:

Fixes #6340

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from kadel and rnapoles-rh December 7, 2022 10:45
@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 8fa1acc
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b6ca4147dddc00085fc5ef

@anandrkskd anandrkskd added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 7, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 7, 2022
@odo-robot
Copy link

odo-robot bot commented Dec 7, 2022 •
edited
Loading

NoCluster Tests on commit c336d69 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 7, 2022 •
edited
Loading

Unit Tests on commit c336d69 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 7, 2022 •
edited
Loading

Validate Tests on commit c336d69 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 7, 2022 •
edited
Loading

Kubernetes Tests on commit c336d69 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 7, 2022 •
edited
Loading

Windows Tests (OCP) on commit c336d69 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 7, 2022 •
edited
Loading

OpenShift Tests on commit c336d69 finished with errors.
View logs: TXT HTML

feloy
feloy suggested changes Dec 12, 2022
View reviewed changes
feloy
feloy suggested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be happy to merge the GitHub action. Could you remove the other files that are not necessary for the moment?

rm3l
rm3l requested changes Dec 16, 2022
View reviewed changes
@anandrkskd anandrkskd force-pushed the tests/6340 branch 2 times, most recently from df0c323 to 86dafe7 Compare December 30, 2022 11:56
@anandrkskd
add ansible,bash scripts and documentation for podman testing
2064c87 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
update documentation for automated podman testing
f9fa979 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Fix: log fetching from vsi
2f07aa0 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
add ssh fetch
cc040ac 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
test podman on Github Actions
047bb12 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd anandrkskd force-pushed the tests/6340 branch 2 times, most recently from f688107 to 23be56e Compare January 3, 2023 11:29
@anandrkskd
remove podman on ibmcloud files
c7e7a91 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
remove podman config check (to test edge case)
abd829b 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

We can use create edge case that we discussed in here, by using config for podman, here is a test run that checked that part.

@feloy, @rm3l, do you want me to remove the config file for podman as well, as it could be used in tests in future?

@feloy
Copy link
Contributor

feloy commented Jan 3, 2023

We can use create edge case that we discussed in here, by using config for podman, here is a test run that checked that part.

@feloy, @rm3l, do you want me to remove the config file for podman as well, as it could be used in tests in future?

I think you can keep the config file, so we can write tests with podman failing asap

Thanks for this PR

@feloy
Copy link
Contributor

feloy commented Jan 3, 2023 •
edited
Loading

@anandrkskd during the test, I can see you get this error:

    [odo]  ✗  Deploying pod [138ms]
    [odo] Cleaning up resources
    [odo]  ✗  volumes already exist, please remove them before to run odo dev: odo-projects-mynodejs-app, odo-shared-data-mynodejs-app

this means that a pod is already running on podman. You will have to check where it comes from (another session, another test, ...)

@rm3l
Copy link
Member

rm3l commented Jan 3, 2023

I can see the test-reporter action is failing because of Error: TypeError: stackTrace.split is not a function..
To not block this PR, it is okay to me if we implement the reporting part in a separate PR if you prefer..

@rm3l
Copy link
Member

rm3l commented Jan 3, 2023 •
edited
Loading

@anandrkskd Can you also update the title of this PR to reflect what this PR now does?
The title will show up as the squash commit message in the Git history, and as it is it no longer matches the diff.

@anandrkskd anandrkskd changed the title add ansible,bash scripts and documentation for podman testing Adding Github Actions for podman testing Jan 4, 2023
@anandrkskd
remove reporter, remove hardcoded component name
76e2f49 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd
Copy link
Contributor Author

/retest

@rm3l rm3l mentioned this pull request Jan 4, 2023
Closed
@anandrkskd @rm3l
Update .github/workflows/podman-test.yaml
8fa1acc 
Co-authored-by: Armel Soro <armel@rm3l.org>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 5, 2023
@rm3l
Copy link
Member

rm3l commented Jan 5, 2023 

• [FAILED] [45.875 seconds]
odo logs command tests
/go/odo_1/tests/integration/cmd_logs_test.go:14
  when component is created and odo logs is executed
  /go/odo_1/tests/integration/cmd_logs_test.go:69
    when running in Deploy mode
    /go/odo_1/tests/integration/cmd_logs_test.go:129
      [It] should successfully show logs of the running component
      /go/odo_1/tests/integration/cmd_logs_test.go:136

...
Expected
      <string>: main: Thu Jan  5 13:14:44 UTC 2023 - this is infinite while loop
      main[1]: 
      main[1]: > nodejs-starter@1.0.0 start /opt/app-root/src
      main[1]: > node server.js
      main[1]: 
      main[1]: App started on PORT 3000
      
  to contain substring
      <string>: main[2]:
  In [It] at: /go/odo_1/tests/helper/helper_generic.go:79
...
Summarizing 1 Failure:
  [FAIL] odo logs command tests when component is created and odo logs is executed when running in Deploy mode [It] should successfully show logs of the running component
  /go/odo_1/tests/helper/helper_generic.go:79

Ran 343 of 603 Specs in 1155.129 seconds
FAIL! -- 342 Passed | 1 Failed | 0 Pending | 260 Skipped

Overriding because this is not related to this PR, but I'm taking a look at this issue as I saw this error reported on more than 2 other PRs.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

• [FAILED] [45.875 seconds]
odo logs command tests
/go/odo_1/tests/integration/cmd_logs_test.go:14
 when component is created and odo logs is executed
 /go/odo_1/tests/integration/cmd_logs_test.go:69
   when running in Deploy mode
   /go/odo_1/tests/integration/cmd_logs_test.go:129
     [It] should successfully show logs of the running component
     /go/odo_1/tests/integration/cmd_logs_test.go:136

...
Expected
     <string>: main: Thu Jan  5 13:14:44 UTC 2023 - this is infinite while loop
     main[1]: 
     main[1]: > nodejs-starter@1.0.0 start /opt/app-root/src
     main[1]: > node server.js
     main[1]: 
     main[1]: App started on PORT 3000
     
 to contain substring
     <string>: main[2]:
 In [It] at: /go/odo_1/tests/helper/helper_generic.go:79
...
Summarizing 1 Failure:
 [FAIL] odo logs command tests when component is created and odo logs is executed when running in Deploy mode [It] should successfully show logs of the running component
 /go/odo_1/tests/helper/helper_generic.go:79

Ran 343 of 603 Specs in 1155.129 seconds
FAIL! -- 342 Passed | 1 Failed | 0 Pending | 260 Skipped

Overriding because this is not related to this PR, but I'm taking a look at this issue as I saw this error reported on more than 2 other PRs.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jan 5, 2023

Infra errors on Prow.

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

Infra errors on Prow.

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit edcd2c7 into redhat-developer:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy requested changes

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@rm3l rm3l

@feloy feloy

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup CI infra for testing odo on Podman
4 participants
@anandrkskd @feloy @rm3l @openshift-merge-robot