Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with OpenShift cluster non authenticated #6395

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Test with OpenShift cluster non authenticated #6395

merged 6 commits into from
Dec 9, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Dec 8, 2022 •
edited
Loading

What type of PR is this:

/kind tests

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Helps test #6379

Run the same tests with NoCluster and with Unauth label.

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 2c74b47
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6392e299267578000835a220

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

OpenShift Tests on commit 02902c4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

NoCluster Tests on commit 02902c4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Unit Tests on commit 02902c4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Validate Tests on commit 02902c4 finished successfully.
View logs: TXT HTML

@feloy feloy requested review from anandrkskd and valaparthvi and removed request for rnapoles-rh December 8, 2022 15:33
@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Kubernetes Tests on commit 02902c4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Windows Tests (OCP) on commit 02902c4 finished successfully.
View logs: TXT HTML

@feloy feloy mentioned this pull request Dec 8, 2022
Merged
3 tasks
@rm3l rm3l added this to the v3.4.0 🚀 milestone Dec 8, 2022
@rm3l rm3l added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Dec 8, 2022
rm3l
rm3l reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but left a few comments.

tests/helper/helper_generic.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.ibm/pipelines/openshift-unauth-tests.sh

(
set -e
make install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other scripts, do we want to also export the DEVFILE_PROXY env var here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proxy running in the cluster, it is not accessible, I had to remove it or it contains an error message

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy requested a review from rm3l December 9, 2022 07:34
rm3l
rm3l approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philippe.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 83cdda6 into redhat-developer:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.4.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@feloy @rm3l @openshift-merge-robot