Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remaining docs consistent #6439

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Make remaining docs consistent #6439

merged 1 commit into from
Dec 28, 2022

Conversation

SD-13
Copy link
Contributor

@SD-13 SD-13 commented Dec 24, 2022 •
edited by valaparthvi
Loading

What type of PR is this:
/area documentation
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6143

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Dec 24, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit dd3ecd4
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63a73ed2e8477700082a79ff
😎 Deploy Preview https://deploy-preview-6439--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/documentation labels Dec 24, 2022
@openshift-ci openshift-ci bot requested review from feloy and valaparthvi December 24, 2022 18:03
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Dec 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2022

Hi @SD-13. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Dec 24, 2022

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 24, 2022 •
edited
Loading

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 24, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@SD-13
Copy link
Contributor Author

SD-13 commented Dec 24, 2022

Hi @valaparthvi , from your mentions, one file is remaining. I am having issues with binding the component and working on it. Will update that soon. Thanks,

@odo-robot
Copy link

odo-robot bot commented Dec 24, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 24, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 24, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I'll merge this for now, you can raise a separate PR for the tutorial, or leave it be for now. I am working on an issue that will probably refactor the doc.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 28, 2022
@valaparthvi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Dec 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit eef699e into redhat-developer:main Dec 28, 2022
@SD-13 SD-13 deleted the consistent_docs_3 branch December 28, 2022 15:28
@SD-13
Copy link
Contributor Author

SD-13 commented Dec 28, 2022

Hey @valaparthvi, thanks for the info, I will leave it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@valaparthvi valaparthvi

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create dropdown menus for examples for user guides / other documentation.
3 participants
@SD-13 @valaparthvi @openshift-merge-robot