Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR for v3.5.0 #6454

Merged
merged 7 commits into from
Jan 5, 2023
Merged

Release PR for v3.5.0 #6454

merged 7 commits into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 4, 2023 •
edited by feloy
Loading

/area documentation
/area release-eng

PR for new release: v3.5.0

Fixes #6411

Feel free to edit and push to this branch.

NOTE: Remove the hold and consider merging this PR only when binaries for this release are publicly available on developers.redhat.com.

@github-actions github-actions bot requested a review from feloy January 4, 2023 10:42
@netlify
Copy link

netlify bot commented Jan 4, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit ec6eaae
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b706b875da9b000989d348
😎 Deploy Preview https://deploy-preview-6454--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering labels Jan 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 4, 2023

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Jan 4, 2023
@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023 •
edited
Loading

NoCluster Tests on commit 570fea3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023 •
edited
Loading

OpenShift Tests on commit 570fea3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023 •
edited
Loading

Unit Tests on commit 570fea3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023 •
edited
Loading

Validate Tests on commit 570fea3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023 •
edited
Loading

Kubernetes Tests on commit 570fea3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023 •
edited
Loading

Windows Tests (OCP) on commit 570fea3 finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Jan 5, 2023
@feloy feloy changed the title [WIP] Release PR for v3.5.0 Release PR for v3.5.0 Jan 5, 2023
@feloy feloy removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Jan 5, 2023
@feloy feloy marked this pull request as ready for review January 5, 2023 14:42
@openshift-ci openshift-ci bot requested a review from rm3l January 5, 2023 14:42
@feloy feloy requested review from valaparthvi and removed request for feloy January 5, 2023 14:47
rm3l
rm3l requested changes Jan 5, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few typos to fix. LGTM otherwise.

docs/website/blog/2023-01-04-odo-v3.5.0.md Outdated Show resolved Hide resolved
docs/website/blog/2023-01-04-odo-v3.5.0.md Outdated Show resolved Hide resolved
feloy and others added 2 commits January 5, 2023 16:14
@feloy @rm3l
Update docs/website/blog/2023-01-04-odo-v3.5.0.md
55f1c33 
Co-authored-by: Armel Soro <asoro@redhat.com>
@feloy @rm3l
Update docs/website/blog/2023-01-04-odo-v3.5.0.md
af660e2 
Co-authored-by: Armel Soro <asoro@redhat.com>
@feloy feloy requested a review from rm3l January 5, 2023 15:16
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 5, 2023
@feloy
Copy link
Contributor

feloy commented Jan 5, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override ci/prow/v4.11-integration-e2e
Non-related tests

@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests, ci/prow/v4.11-integration-e2e

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override ci/prow/v4.11-integration-e2e
Non-related tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 5, 2023
valaparthvi
valaparthvi suggested changes Jan 5, 2023
View reviewed changes
docs/website/blog/2023-01-04-odo-v3.5.0.md Outdated

#### Allow fetching a specific Devfile Stack version

Version 3.4.0 of odo introduced the support of versioned Devfile stacks, with the ability to list available versions od Devfile stacks. Starting with version 3.5.0, you can initialize a new project with a specific version of a Devfile stack. Previously, the default version were used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version 3.4.0 of odo introduced the support of versioned Devfile stacks, with the ability to list available versions od Devfile stacks. Starting with version 3.5.0, you can initialize a new project with a specific version of a Devfile stack. Previously, the default version were used.
Version 3.4.0 of odo introduced the support of versioned Devfile stacks, with the ability to list available versions of Devfile stacks. Starting with version 3.5.0, you can initialize a new project with a specific version of a Devfile stack. Previously, the default version were used.

docs/website/blog/2023-01-04-odo-v3.5.0.md Outdated Show resolved Hide resolved
docs/website/blog/2023-01-04-odo-v3.5.0.md Outdated Show resolved Hide resolved
docs/website/blog/2023-01-04-odo-v3.5.0.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 5, 2023
@valaparthvi
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 5, 2023
@feloy @valaparthvi
Apply suggestions from code review
ec6eaae 
Co-authored-by: Parthvi Vala <pvala@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 5, 2023
@feloy
Copy link
Contributor

feloy commented Jan 5, 2023

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0fa6153 into main Jan 5, 2023
@rm3l rm3l deleted the blog_post_v3.5.0 branch January 5, 2023 22:07
@rm3l rm3l restored the blog_post_v3.5.0 branch January 5, 2023 22:07
@rm3l rm3l deleted the blog_post_v3.5.0 branch January 5, 2023 22:07
@rm3l rm3l added this to the v3.5.0 🚀 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi approved these changes

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

@valaparthvi valaparthvi

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v3.5.0 🚀
Development

Successfully merging this pull request may close these issues.

🎉 Release for Sprint 229 (v3.5.0) 🎉
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot