-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix odo init output in java quickstart guide #6462
Fix odo init output in java quickstart guide #6462
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the commit message (and PR title) is more about the output of odo init
, not odo dev
.. Can you reword the commit message (and optionally the PR title), so it corresponds to the diff?
My bad 🤦 |
No problem. Actually, can you reword the commit message as well? Since there is a single commit in this PR, I think the Merge Robot will use that as the squashed commit message. So I'd say it is more important to me to have the right information in the Git history. |
Yes, sorry. I was working on something else and forgot. Will do it. |
Signed-off-by: Parthvi Vala <pvala@redhat.com>
6cbfa78
to
8c64ddc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/override OpenShift-Integration-tests/OpenShift-Integration-tests Failures are unrelated to the PR changes. |
@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Parthvi Vala pvala@redhat.com
What type of PR is this:
/kind bug
/area documentation
What does this PR do / why we need it:
This PR fixes a bug with
odo dev
output for Java springboot quickstart.Which issue(s) this PR fixes:
Fixes #
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: