Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odo init output in java quickstart guide #6462

Merged

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind bug
/area documentation

What does this PR do / why we need it:
This PR fixes a bug with odo dev output for Java springboot quickstart.
Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 8c64ddc
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b69900afc4b300080dc2c6

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Jan 4, 2023
@openshift-ci openshift-ci bot requested review from feloy and rm3l January 4, 2023 19:02
@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023

NoCluster Tests on commit a82c3c8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023

OpenShift Tests on commit a82c3c8 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023

Unit Tests on commit a82c3c8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023

Validate Tests on commit a82c3c8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023

Kubernetes Tests on commit a82c3c8 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 4, 2023

Windows Tests (OCP) on commit a82c3c8 finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message (and PR title) is more about the output of odo init, not odo dev.. Can you reword the commit message (and optionally the PR title), so it corresponds to the diff?

@valaparthvi
Copy link
Contributor Author

LGTM, but the commit message (and PR title) is more about the output of odo init, not odo dev.. Can you reword the commit message (and optionally the PR title), so it corresponds to the diff?

My bad 🤦

@valaparthvi valaparthvi changed the title Fix odo dev output in java quickstart guide Fix odo init output in java quickstart guide Jan 5, 2023
@rm3l
Copy link
Member

rm3l commented Jan 5, 2023

LGTM, but the commit message (and PR title) is more about the output of odo init, not odo dev.. Can you reword the commit message (and optionally the PR title), so it corresponds to the diff?

My bad facepalm

No problem. Actually, can you reword the commit message as well? Since there is a single commit in this PR, I think the Merge Robot will use that as the squashed commit message. So I'd say it is more important to me to have the right information in the Git history.

@valaparthvi
Copy link
Contributor Author

LGTM, but the commit message (and PR title) is more about the output of odo init, not odo dev.. Can you reword the commit message (and optionally the PR title), so it corresponds to the diff?

My bad facepalm

No problem. Actually, can you reword the commit message as well? Since there is a single commit in this PR, I think the Merge Robot will use that as the squashed commit message. So I'd say it is more important to me to have the right information in the Git history.

Yes, sorry. I was working on something else and forgot. Will do it.

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@valaparthvi
Copy link
Contributor Author

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Failures are unrelated to the PR changes.

@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Failures are unrelated to the PR changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit bf947eb into redhat-developer:main Jan 5, 2023
@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants