Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the port value (20001) in the quickstart guides #6570

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 3, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:
The sample output displayed at the end of the Quickstart Guides no longer matches the port number we are instructing users to reach in order to access the application.

Screenshot from 2023-02-03 17-33-00

This PR changes the value displayed and adds an additional clarification line.

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 21f6781
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63dd3e3e37fd8e0009141f41
😎 Deploy Preview https://deploy-preview-6570--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 3, 2023

Kubernetes Docs Tests on commit eeda644 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 3, 2023
@feloy
Copy link
Contributor

feloy commented Feb 3, 2023

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3f01c3f into redhat-developer:main Feb 3, 2023
@rm3l rm3l deleted the fix_dev_port_value_in_quickstart_guides branch February 3, 2023 19:37
@rm3l rm3l added this to the v3.7.0 🚀 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants