-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go to 1.19 #6586
Bump Go to 1.19 #6586
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
/hold For several reasons:
|
go mod edit -go=1.19
…gci-lint SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
1beb9a8
to
4c0c852
Compare
/hold cancel Removing the hold, since CWFCONF-3455 has been resolved and I've checked that Golang 1.19 was available internally. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Flaky test. /override OpenShift-Integration-tests/OpenShift-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6581
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: