Add name detection to odo analyze
#6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
valaparthvi
changed the title
odo analyzeodo analyze
openshift-ci
bot
added
the
do-not-merge/work-in-progress
valaparthvi
requested review from
feloy and
rm3l
and removed request for
anandrkskd and
rnapoles-rh
valaparthvi
changed the title
odo analyzeodo analyze
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Parthvi Vala <pvala@redhat.com>
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests [FAILED] Timed out after 180.001s.
Expected
<string>: âš Pod is Terminating
✗ Finished executing the application (command: devrun) [42s]
âš No pod exists
âš Pod is Pending
✓ Pod is Running
• Syncing files into the container ...
✓ Syncing files into the container [729ms]
• Building your application in container (command: devbuild) ...
✓ Building your application in container (command: devbuild) [4s]
• Executing the application (command: devrun) ...
- Forwarding from 127.0.0.1:46755 -> 3000
↪ Dev mode
Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
[p] - Manually apply local changes to the application on the cluster
To satisfy at least one of these matchers: [%!s(*matchers.ContainSubstringMatcher=&{Pushing files... []}) %!s(*matchers.ContainSubstringMatcher=&{Updating Component... []})]
In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:64 @ 03/26/23 09:31:00.809
[FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override windows-integration-test/Windows-test Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375
Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375 on attempt #10, trying again...
[odo] I0326 04:35:14.791379 9708 watch.go:449] Copying files [] to pod
[odo] I0326 04:35:14.791570 9708 util.go:198] path devfile.yaml doesn't exist, skipping it
[odo] I0326 04:35:14.791570 9708 util.go:198] path .devfile.yaml doesn't exist, skipping it
[odo] I0326 04:35:14.791570 9708 context.go:159] absolute devfile path: 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml'
[odo] I0326 04:35:14.791570 9708 context.go:110] absolute devfile path: 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml'
[odo] I0326 04:35:14.791570 9708 watch.go:470] Error from Push: unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml: The system cannot find the file specified.
[odo] I0326 04:35:14.791570 9708 backo.go:23] wait for 10s
[odo] Error occurred on Push - unable to generate component from watch parameters: failed to populateAndParseDevfile: failed to read devfile from path 'C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml': open C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375\devfile.yaml: The system cannot find the file specified.
[odo]
Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375
Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2606349375 on attempt #11, trying again...
[FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3483/tests/helper/helper_filesystem.go:48 @ 03/26/23 04:35:23.957
<< Timeline
[FAILED] Expected
<*url.Error | 0xc0000b9020>: {
Op: "Post",
URL: "http://127.0.0.1:61069/api/newuser",
Err: <*errors.errorString | 0xc000088130>{s: "EOF"},
}
to be nil
In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3483/tests/e2escenarios/e2e_test.go:306 @ 03/26/23 04:33:17.6
There were additional failures detected. To view them in detail run ginkgo -vv
------------------------------
Summarizing 1 Failure:
[FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Can you also update the odo analyze documentation and sample output?
https://odo.dev/docs/command-reference/json-output#odo-analyze--o-json
This PR should fix #6649, no? |
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
approved these changes
Mar 28, 2023
openshift-ci
bot
added
the
lgtm
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ci/prow/v4.12-images |
|
@valaparthvi: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test v4.12-images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
This PR adds missing name detection to
odo analyzeWhich issue(s) this PR fixes:
Fixes #6649
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
mkdir /tmp/demo; cd /tmp/demoodo init --devfile go --name my-go-app --starter go-starter --devfile-version latestodo analyze -o json