-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc and blog post about using in-cluster Devfile registries #6689
Add doc and blog post about using in-cluster Devfile registries #6689
Conversation
…red in the cluster
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
37a4a41
to
7fa2d16
Compare
7fa2d16
to
09e59cc
Compare
- `ClusterDevfileRegistriesList`: installable at the cluster level | ||
- `DevfileRegistriesList`: installable at the namespace level | ||
|
||
More details on the [Devfile Registry Operator documentation](https://github.com/devfile/registry-operator/blob/main/REGISTRIES_LISTS.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add a note that such registries are not necessarily running into the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 2fe2050
(#6689)
|
||
On Kubernetes, the Helm Chart installed above will create an Ingress reachable via a DNS domain named as follows: `devfile-registry-<namespace>.<ingressDomain>`. | ||
|
||
You can get the actual Host by getting the Ingress Resource, via the following command: `kubectl get ingress <registryName>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
I would add the command in a code block so that it can be copied and is consistent with other code blocks. Same comment for oc get route
You can get the actual Host by getting the Ingress Resource, via the following command: `kubectl get ingress <registryName>`. | |
You can get the actual Host by getting the Ingress Resource, via the following command: | |
```sh | |
kubectl get ingress <registryName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9257b82
(#6689)
DefaultDevfileRegistry https://registry.devfile.io Yes | ||
|
||
``` | ||
</details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you can add a link to the blog at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in ff4689e
(#6689)
devfile-registry-default.172.20.0.2.nip.io | ||
``` | ||
|
||
In this example, the Devfile Registry is now reachable at http://devfile-registry-default.172.20.0.2.nip.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be helpful to add a note that it may take 1 or 2 minutes before the address is accessible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed - that could be helpful. Added in 9257b82
(#6689)
…r Devfile registry
…s declared in the cluster
…r Devfile registry
…s declared in the cluster
Kudos, SonarCloud Quality Gate passed! |
/override OpenShift-Integration-tests/OpenShift-Integration-tests Doc-only PR. |
@rm3l: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ODO-PODMAN-TEST |
@rm3l: Overrode contexts on behalf of rm3l: ODO-PODMAN-TEST In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/area documentation
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6646
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: