Support variable substitution with --var and --var-file in odo build-images

[rm3l]

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6274

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

You can run odo build-images [--var ... | --var-file ...] using the Devfile used in the tests (tests/examples/source/devfiles/nodejs/devfile-variables.yaml) or any Devfile where image names are variables (like in our Advanced Guides for deploying apps)

[netlify]

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	5c3dc53
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/644a204551be9000086e7ced
😎 Deploy Preview	https://deploy-preview-6776--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[odo-robot]

NoCluster Tests on commit 331e8cb finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Unauthenticated Tests on commit 331e8cb finished successfully.
View logs: TXT HTML

[odo-robot]

Unit Tests on commit 331e8cb finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit 331e8cb finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit 331e8cb finished with errors.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit 331e8cb finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Docs Tests on commit 5913097 finished successfully.
View logs: TXT HTML

[valaparthvi]

/override windows-integration-test/Windows-test

Windows Failure:

Summarizing 4 Failures:
  [FAIL] odo remove binding command tests [AfterEach] when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-k8s) when odo dev is running when binding is removed should have led odo dev to delete ServiceBinding from the cluster
  C:/Users/Administrator.ANSIBLE-TEST-VS/3828/tests/helper/helper_cmd_wrapper.go:101
  [FAIL] odo add binding interactive command tests [BeforeEach] when the component is bootstrapped should successfully add binding to the devfile ("lowercase" as naming strategy)
  C:/Users/Administrator.ANSIBLE-TEST-VS/3828/tests/helper/helper_generic.go:58
  [FAIL] odo logs command tests [BeforeEach] when component is created and odo logs is executed when running in both Dev and Deploy mode should successfully show logs of the running component
  C:/Users/Administrator.ANSIBLE-TEST-VS/3828/tests/helper/helper_cmd_wrapper.go:101
  [FAIL] odo describe/list binding command tests [BeforeEach] when creating a component with a binding (service in namespace "") should list the binding without running odo dev ([list])
  C:/Users/Administrator.ANSIBLE-TEST-VS/3828/tests/helper/helper_cmd_wrapper.go:101

Ran 449 of 830 Specs in 1967.082 seconds
FAIL! -- 445 Passed | 4 Failed | 0 Pending | 381 Skipped

All issues relate to network connectivity.

[valaparthvi]

/override windows-integration-test/Windows-test

[openshift-ci]

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[odo-robot]

OpenShift Tests on commit 331e8cb finished with errors.
View logs: TXT HTML

[rm3l]

• [FAILED] [471.677 seconds]
odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
...
  [odo] I0427 10:47:06.267582   28067 delete.go:94] failed to delete resource "my-nodejs-app-cluster-sample-ocp" (binding.operators.coreos.com.v1alpha1.servicebindings): timeout while waiting for "my-nodejs-app-cluster-sample-ocp" resource to be deleted

  [FAILED] Timed out after 180.000s.
  Expected process to exit.  It did not.
  In [AfterEach] at: /go/odo_1/tests/helper/helper_dev.go:213 @ 04/27/23 10:47:07.106
...
Summarizing 1 Failure:
  [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
  /go/odo_1/tests/helper/helper_dev.go:213

Ran 458 of 830 Specs in 2435.435 seconds
FAIL! -- 457 Passed | 1 Failed | 0 Pending | 372 Skipped

Unrelated.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[openshift-ci]

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

• [FAILED] [471.677 seconds]
odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
...
 [odo] I0427 10:47:06.267582   28067 delete.go:94] failed to delete resource "my-nodejs-app-cluster-sample-ocp" (binding.operators.coreos.com.v1alpha1.servicebindings): timeout while waiting for "my-nodejs-app-cluster-sample-ocp" resource to be deleted

 [FAILED] Timed out after 180.000s.
 Expected process to exit.  It did not.
 In [AfterEach] at: /go/odo_1/tests/helper/helper_dev.go:213 @ 04/27/23 10:47:07.106
...
Summarizing 1 Failure:
 [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
 /go/odo_1/tests/helper/helper_dev.go:213

Ran 458 of 830 Specs in 2435.435 seconds
FAIL! -- 457 Passed | 1 Failed | 0 Pending | 372 Skipped

Unrelated.

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.