-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check latest version from index instead of using hardcoded value #6789
Check latest version from index instead of using hardcoded value #6789
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you fixing this!
There is one more test related to the JSON output that needs to be fixed though.
@@ -159,11 +160,12 @@ var _ = Describe("odo devfile init command tests", func() { | |||
|
|||
for _, ctx := range []struct { | |||
title, devfileVersion, requiredVersion string | |||
gotLatest bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge the changes from #6788 as well, use a dedicated versionCheck
instead of gotLatest
.
1405830
to
3f42724
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
OpenShift Failures: [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
[FAILED] Expected
<*url.Error | 0xc0004e2d50>: {
Op: "Post",
URL: "http://127.0.0.1:35493/api/newuser",
Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
}
to be nil
In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/04/23 17:17:37.014
• [FAILED] [123.250 seconds]
E2E Test starting with non-empty Directory test debugging [It] should verify developer workflow from non-empty Directory
? What configuration do you want change? Add new environment variable
? Enter new environment variable name:
======================
Unexpected error:
<*xpty.errPassthroughTimeout | 0xc000f0c010>: {
error: <*errors.errorString | 0xc000f0c000>{
s: "passthrough i/o timeout",
},
}
passthrough i/o timeout
occurred
In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 05/04/23 17:18:18.077 Windows test: Summarizing 1 Failure:
[FAIL] odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [It] should mount the volumes
C:/Users/Administrator.ANSIBLE-TEST-VS/3893/tests/helper/helper_cmd_wrapper.go:101
[FAILED] No future change is possible. Bailing out early after 21.328s.
Running oc.exe with args [oc exec zelwvo-app-75459dcfb9-8cml8 --namespace cmd-dev-test634mnt -c runtime -- cat /etc/config0444] and odo env: []
Expected
<int>: 1
to match exit code:
<int>: 0
In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3893/tests/helper/helper_cmd_wrapper.go:101 @ 05/04/23 11:40:40.213
------------------------------ |
/override OpenShift-Integration-tests/OpenShift-Integration-tests /lgtm |
@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
/area testing
What does this PR do / why we need it:
An integration test is failing after registry is updated and the Go stack got a new version.
Instead of hardcoding the value of the latest version of the Go stack, the latest value is obtained by reading the index of the Devfile Registry.
Which issue(s) this PR fixes:
Fixes #
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: