Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check latest version from index instead of using hardcoded value #6789

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 4, 2023

What type of PR is this:

/kind bug
/area testing

What does this PR do / why we need it:

An integration test is failing after registry is updated and the Go stack got a new version.

[FAILED] Expected
      <string>: 2.1.0
  to be equivalent to
      <string>: 2.0.0
  In [It] at: /go/src/github.com/redhat-developer/odo/tests/integration/cmd_devfile_init_test.go:187 @ 05/04/23 00:38:54.514

Instead of hardcoding the value of the latest version of the Go stack, the latest value is obtained by reading the index of the Devfile Registry.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 8ea2541
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6453c61771e39600087bfcac

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels May 4, 2023
@feloy feloy requested review from rm3l and valaparthvi May 4, 2023 07:56
@feloy feloy changed the title Check latest version from index instead of using harcoded value Check latest version from index instead of using hardcoded value May 4, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and ritudes May 4, 2023 07:57
@odo-robot
Copy link

odo-robot bot commented May 4, 2023

NoCluster Tests on commit c5b90ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023

OpenShift Unauthenticated Tests on commit c5b90ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023

Unit Tests on commit c5b90ee finished successfully.
View logs: TXT HTML

Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fixing this!
There is one more test related to the JSON output that needs to be fixed though.

@@ -159,11 +160,12 @@ var _ = Describe("odo devfile init command tests", func() {

for _, ctx := range []struct {
title, devfileVersion, requiredVersion string
gotLatest bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge the changes from #6788 as well, use a dedicated versionCheck instead of gotLatest.

@feloy feloy force-pushed the tests/fix-devfile-version branch from 1405830 to 3f42724 Compare May 4, 2023 08:19
@feloy feloy requested a review from valaparthvi May 4, 2023 08:20
@odo-robot
Copy link

odo-robot bot commented May 4, 2023

Validate Tests on commit c5b90ee finished successfully.
View logs: TXT HTML

@rm3l rm3l added this to the v3.11.0 🚀 milestone May 4, 2023
@odo-robot
Copy link

odo-robot bot commented May 4, 2023

Windows Tests (OCP) on commit c5b90ee finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023

Kubernetes Tests on commit c5b90ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023

OpenShift Tests on commit c5b90ee finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023

Kubernetes Docs Tests on commit 6dd357d finished successfully.
View logs: TXT HTML

@feloy feloy closed this May 4, 2023
@feloy feloy reopened this May 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valaparthvi
Copy link
Contributor

OpenShift Failures:

  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop

  [FAILED] Expected
      <*url.Error | 0xc0004e2d50>: {
          Op: "Post",
          URL: "http://127.0.0.1:35493/api/newuser",
          Err: <*errors.errorString | 0xc000072130>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/04/23 17:17:37.014


• [FAILED] [123.250 seconds]
E2E Test starting with non-empty Directory test debugging [It] should verify developer workflow from non-empty Directory
  ? What configuration do you want change? Add new environment variable
  ? Enter new environment variable name: 
  ======================
  Unexpected error:
      <*xpty.errPassthroughTimeout | 0xc000f0c010>: {
          error: <*errors.errorString | 0xc000f0c000>{
              s: "passthrough i/o timeout",
          },
      }
      passthrough i/o timeout
  occurred
  In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 05/04/23 17:18:18.077

Windows test:

Summarizing 1 Failure:
  [FAIL] odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [It] should mount the volumes
  C:/Users/Administrator.ANSIBLE-TEST-VS/3893/tests/helper/helper_cmd_wrapper.go:101

  [FAILED] No future change is possible.  Bailing out early after 21.328s.
  Running oc.exe with args [oc exec zelwvo-app-75459dcfb9-8cml8 --namespace cmd-dev-test634mnt -c runtime -- cat /etc/config0444] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3893/tests/helper/helper_cmd_wrapper.go:101 @ 05/04/23 11:40:40.213
------------------------------

@valaparthvi
Copy link
Contributor

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 5, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 32e2df0 into redhat-developer:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants