Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spinner when determining a devfile using alizer #6793

Merged
merged 5 commits into from
May 16, 2023
Merged

Add spinner when determining a devfile using alizer #6793

merged 5 commits into from
May 16, 2023

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6780

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
TODO: Fix panic on Ctrl+c with odo dev

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 82ebfe5
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64631977f450d40008901faf
😎 Deploy Preview https://deploy-preview-6793--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from anandrkskd and kadel May 4, 2023 12:16
@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

Windows Tests (OCP) on commit 51743ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

NoCluster Tests on commit 51743ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 51743ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

Unit Tests on commit 51743ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

Validate Tests on commit 51743ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

Kubernetes Tests on commit 51743ed finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

Kubernetes Docs Tests on commit d23789a finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 4, 2023 •
edited
Loading

OpenShift Tests on commit 51743ed finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi changed the title WIP: Add spinner when determining a devfile using alizer Add spinner when determining a devfile using alizer May 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 9, 2023
@valaparthvi valaparthvi changed the title Add spinner when determining a devfile using alizer WIP: Add spinner when determining a devfile using alizer May 10, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 10, 2023
@valaparthvi valaparthvi changed the title WIP: Add spinner when determining a devfile using alizer Add spinner when determining a devfile using alizer May 11, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 11, 2023
valaparthvi and others added 4 commits May 15, 2023 19:54
@valaparthvi
Add spinner when determining a devfile using alizer and handle panic …
78df7ef 
…on odo dev

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi @feloy @rm3l
Change HandleSignal signature, handle context cancellation in AlizerB…
70307a7 
…ackend Select Devfile

Co-authored-by: Philippe Martin <phmartin@redhat.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi
Fix spinner and terminate on terminal interrupt
d61f387 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi
Fix validation errors
e69d798 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 15, 2023
@valaparthvi
Fix doc test error
82ebfe5 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@feloy
Copy link
Contributor

feloy commented May 16, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [0.357 seconds]
odo dev debug command tests [BeforeEach] when a composite command is used as debug command - with metadata.name should run successfully
  [BeforeEach] /go/odo_1/tests/integration/cmd_dev_debug_test.go:25
  [It] /go/odo_1/tests/integration/cmd_dev_debug_test.go:230

[...]

  [kubectl] Error from server (AlreadyExists): namespaces "cmd-dev-debug-test230mel" already exists

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [0.357 seconds]
odo dev debug command tests [BeforeEach] when a composite command is used as debug command - with metadata.name should run successfully
 [BeforeEach] /go/odo_1/tests/integration/cmd_dev_debug_test.go:25
 [It] /go/odo_1/tests/integration/cmd_dev_debug_test.go:230

[...]

 [kubectl] Error from server (AlreadyExists): namespaces "cmd-dev-debug-test230mel" already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented May 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 16, 2023
@feloy
Copy link
Contributor

feloy commented May 16, 2023

/override kubernetes-infra-stage-test

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: Overrode contexts on behalf of feloy: kubernetes-infra-stage-test

In response to this:

/override kubernetes-infra-stage-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a6da3e0 into redhat-developer:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

@feloy feloy

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo dev freezes then panics when run from ~
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot