Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse same volumes when devfile is modified, on podman #6810

Merged
merged 2 commits into from
May 11, 2023
Merged

Reuse same volumes when devfile is modified, on podman #6810

merged 2 commits into from
May 11, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 10, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6458

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 10, 2023
@netlify
Copy link

netlify bot commented May 10, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 2505149
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/645c873c1c89a9000881bdb4
😎 Deploy Preview https://deploy-preview-6810--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from rm3l and valaparthvi May 10, 2023 14:43
@odo-robot
Copy link

odo-robot bot commented May 10, 2023 •
edited
Loading

NoCluster Tests on commit 217c4f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 10, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 217c4f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 10, 2023 •
edited
Loading

Unit Tests on commit 217c4f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 10, 2023 •
edited
Loading

Validate Tests on commit 217c4f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 10, 2023 •
edited
Loading

Windows Tests (OCP) on commit 217c4f9 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 10, 2023 •
edited
Loading

Kubernetes Docs Tests on commit da28e7d finished successfully.
View logs: TXT HTML

rm3l
rm3l reviewed May 10, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I was thinking we could update the Podman Support limitations documentation? The "Pod not updated when Devfile changes" section is no longer a limitation on Podman then.
This is part of the acceptance criteria of #6458

pkg/dev/podmandev/reconcile.go Outdated Show resolved Hide resolved
@feloy feloy requested a review from rm3l May 11, 2023 06:12
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented May 11, 2023

Kubernetes Tests on commit 217c4f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 11, 2023

OpenShift Tests on commit 217c4f9 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 11, 2023
@rm3l rm3l added this to the v3.11.0 🚀 milestone May 11, 2023
@feloy
Copy link
Contributor Author

feloy commented May 11, 2023

/override windows-integration-test/Windows-test

  [oc] Unable to connect to the server: dial tcp 149.81.180.114:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

 [oc] Unable to connect to the server: dial tcp 149.81.180.114:30329: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f491bcc into redhat-developer:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.11.0 🚀
Development

Successfully merging this pull request may close these issues.

Restart pod on Podman when related information is changed in Devfile
3 participants
@feloy @rm3l @openshift-merge-robot