Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use odo logo instead of author image in blog posts #6837

Merged
merged 3 commits into from
May 24, 2023
Merged

Use odo logo instead of author image in blog posts #6837

merged 3 commits into from
May 24, 2023

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented May 23, 2023 •
edited
Loading

What type of PR is this:
/area documentation
/area release-eng

What does this PR do / why we need it:
While sharing blogs on social media platform, the author image is highlighted in big picture which is not always desirable. Using odo logo instead seems like a better option.

Which issue(s) this PR fixes:

Fixes #6807

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@valaparthvi
Use odo logo instead of author image in blog posts
bd73846 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@valaparthvi valaparthvi marked this pull request as ready for review May 23, 2023 10:59
@netlify
Copy link

netlify bot commented May 23, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit df674d2
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/646cd841ae7e8400084db959
😎 Deploy Preview https://deploy-preview-6837--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels May 23, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy May 23, 2023 10:59
@odo-robot
Copy link

odo-robot bot commented May 23, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 42a965b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023 •
edited
Loading

NoCluster Tests on commit 42a965b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023 •
edited
Loading

Unit Tests on commit 42a965b finished successfully.
View logs: TXT HTML

kadel
kadel reviewed May 23, 2023
View reviewed changes
.github/workflow-data/release-management/blog-post-header.tpl.md Outdated
@@ -2,7 +2,7 @@
title: odo ${TAG_NAME} Released
author: $GITHUB_ACTOR
author_url: https://github.com/$GITHUB_ACTOR
author_image_url: https://github.com/$GITHUB_ACTOR.png
author_image_url: https://raw.githubusercontent.com/redhat-developer/odo/main/docs/website/static/img/logo.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep author_image_url as it was; it is correct that it points to GitHub avatar.

According to Docusarus documentation there is also an image field that should be used to this

We should probably set image to odo logo for this template and all existing blog posts.

@odo-robot
Copy link

odo-robot bot commented May 23, 2023 •
edited
Loading

Validate Tests on commit 42a965b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023 •
edited
Loading

Kubernetes Tests on commit 42a965b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

rm3l
rm3l reviewed May 23, 2023
View reviewed changes
.github/workflow-data/release-management/blog-post-header.tpl.md
@@ -3,6 +3,7 @@ title: odo ${TAG_NAME} Released
author: $GITHUB_ACTOR
author_url: https://github.com/$GITHUB_ACTOR
author_image_url: https://github.com/$GITHUB_ACTOR.png
image: https://raw.githubusercontent.com/redhat-developer/odo/main/docs/website/static/img/logo.png
Copy link
Member

@rm3l rm3l May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this to all existing release announcement posts?

rm3l
rm3l reviewed May 23, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes #6807, right?

@odo-robot
Copy link

odo-robot bot commented May 23, 2023 •
edited
Loading

Kubernetes Docs Tests on commit dcf9009 finished successfully.
View logs: TXT HTML

@valaparthvi
Add image to all the blog posts
df674d2 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi
Copy link
Contributor Author

Works as expected!

image

@valaparthvi valaparthvi requested a review from rm3l May 23, 2023 15:19
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

OpenShift Tests on commit 42a965b finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit dcbc60a into redhat-developer:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel left review comments

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website area/release-eng Issues or PRs related to the Release Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update odo blog release with odo thumbnails
4 participants
@valaparthvi @kadel @rm3l @openshift-merge-robot