Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark issues and pull requests as stale #6872

Merged
merged 8 commits into from
Jun 9, 2023

Conversation

ritudes
Copy link
Contributor

@ritudes ritudes commented Jun 7, 2023

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6610

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Ritu Deshmukh <rideshmu@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 7, 2023
@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d376218
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64830be53691410008410bb8

@openshift-ci openshift-ci bot requested review from anandrkskd and kadel June 7, 2023 08:34
@ritudes ritudes requested a review from rm3l June 7, 2023 08:34
@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

OpenShift Unauthenticated Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

NoCluster Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

Unit Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

Validate Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

Kubernetes Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

Kubernetes Docs Tests on commit 029c538 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023

OpenShift Tests on commit daf1e6c finished with errors.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions:

  • Changed the number of days before marking an issue/PR as stale, and before closing it. Based on what I can see from old issues like this one, issues were marked as stale after 90 days of inactivity, and rotten/closed after an additional 30d of inactivity. I think this makes better sense.
  • Leverage the lifecycle/* labels we already have: https://github.com/redhat-developer/odo/labels?q=lifecycle
    • This is useful in certain cases to exempt issues with certain labels from this action, for example, if they are explicitly labeled as active or frozen.
  • More details in the stale message about when the issue will be closed

.github/workflows/stale.yaml Outdated Show resolved Hide resolved
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
ritudes and others added 7 commits June 9, 2023 16:52
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
Co-authored-by: Armel Soro <armel@rm3l.org>
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ritudes
Copy link
Contributor Author

ritudes commented Jun 9, 2023

Thank you for your reviews @rm3l .I have applied those changes as per your suggestions

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 9, 2023
@rm3l rm3l changed the title [WIP]Mark issues and pull requests as stale Mark issues and pull requests as stale Jun 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 9, 2023
@rm3l
Copy link
Member

rm3l commented Jun 9, 2023

  [FAILED] registry_list_output.mdx
  Expected
      <string>:   strings.Join({
        	... // 108 identical bytes
        	"                        VERSIONS\nnodejs-react  StagingRegistry  ",
        	"       React is a free and open-source front-en...  2.0.2, 2.1.0",
      + 	", 2.2.0",
        	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
        	"source front-en...  2.0.2, 2.1.0\n```\n",
        }, "")
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/09/23 12:49:03.116
------------------------------
••••••Spawning '/go/bin/odo init' from /tmp/591808707
•••Spawning '/go/bin/odo delete project odo-dev' from /tmp/2208322380
••••

Summarizing 1 Failure:
  [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
  /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Ran 16 of 16 Specs in 46.762 seconds
FAIL! -- 15 Passed | 1 Failed | 0 Pending | 0 Skipped

Reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

 [FAILED] registry_list_output.mdx
 Expected
     <string>:   strings.Join({
       	... // 108 identical bytes
       	"                        VERSIONS\nnodejs-react  StagingRegistry  ",
       	"       React is a free and open-source front-en...  2.0.2, 2.1.0",
     + 	", 2.2.0",
       	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
       	"source front-en...  2.0.2, 2.1.0\n```\n",
       }, "")
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/09/23 12:49:03.116
------------------------------
••••••Spawning '/go/bin/odo init' from /tmp/591808707
•••Spawning '/go/bin/odo delete project odo-dev' from /tmp/2208322380
••••

Summarizing 1 Failure:
 [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
 /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Ran 16 of 16 Specs in 46.762 seconds
FAIL! -- 15 Passed | 1 Failed | 0 Pending | 0 Skipped

Reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jun 9, 2023

...
 [odo]  âš   AttachVolume.Attach failed for volume "pvc-76ffbf80-442b-4a64-825b-8b931bde3264" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-796cee09-5495-42c5-9c28-f0c09c729b4a
  [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-5hsp9]: timed out waiting for the condition
  [FAILED] in [BeforeEach] - /go/odo_1/tests/helper/helper_run.go:54 @ 06/09/23 12:33:41.225
  Deleting project: cmd-dev-test468xck
...
  [odo]  âš   AttachVolume.Attach failed for volume "pvc-dbbed17f-7a30-40d4-b0a5-ac4470f8ae04" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-e0f0bcbe-af9b-45ae-8a75-4ecf629092ef
  [odo]  âš   AttachVolume.Attach failed for volume "pvc-a48b435e-ac81-498e-9cd1-fdc4f9e6b79a" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-61568a66-adc6-417b-89d0-d0bc25dc8449
  [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[firstvol-araele-app-vol secondvol-araele-app-vol], unattached volumes=[odo-projects odo-shared-data firstvol-araele-app-vol secondvol-araele-app-vol kube-api-access-jj9qx]: timed out waiting for the condition
...

Summarizing 2 Failures:
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54

Ran 489 of 932 Specs in 1569.096 seconds
FAIL! -- 487 Passed | 2 Failed | 0 Pending | 443 Skipped

Issues with attaching volumes on OpenShift.
Overriding because the changes here are only about adding a new GitHub Workflow for housekeeping..

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

...
[odo]  âš   AttachVolume.Attach failed for volume "pvc-76ffbf80-442b-4a64-825b-8b931bde3264" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-796cee09-5495-42c5-9c28-f0c09c729b4a
 [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-5hsp9]: timed out waiting for the condition
 [FAILED] in [BeforeEach] - /go/odo_1/tests/helper/helper_run.go:54 @ 06/09/23 12:33:41.225
 Deleting project: cmd-dev-test468xck
...
 [odo]  âš   AttachVolume.Attach failed for volume "pvc-dbbed17f-7a30-40d4-b0a5-ac4470f8ae04" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-e0f0bcbe-af9b-45ae-8a75-4ecf629092ef
 [odo]  âš   AttachVolume.Attach failed for volume "pvc-a48b435e-ac81-498e-9cd1-fdc4f9e6b79a" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-61568a66-adc6-417b-89d0-d0bc25dc8449
 [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[firstvol-araele-app-vol secondvol-araele-app-vol], unattached volumes=[odo-projects odo-shared-data firstvol-araele-app-vol secondvol-araele-app-vol kube-api-access-jj9qx]: timed out waiting for the condition
...

Summarizing 2 Failures:
 [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54

Ran 489 of 932 Specs in 1569.096 seconds
FAIL! -- 487 Passed | 2 Failed | 0 Pending | 443 Skipped

Issues with attaching volumes on OpenShift.
Overriding because the changes here are only about adding a new GitHub Workflow for housekeeping..

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d892e8e into redhat-developer:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bot marking issues as stale and rotten
3 participants