Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace odo delete component integration with unit tests #6904

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Replace odo delete component integration with unit tests #6904

merged 1 commit into from
Jun 21, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 16, 2023 •
edited
Loading

What type of PR is this:

/kind code-refactoring
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes partially #6889

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@feloy feloy temporarily deployed to external June 16, 2023 07:10 — with GitHub Actions Inactive
@netlify
Copy link

netlify bot commented Jun 16, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit f233d25
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64915fa0e474cb00081ccfc1

@openshift-ci openshift-ci bot added kind/code-refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Jun 16, 2023
@feloy feloy changed the title Replace odo delete component integration with unit tests [wip] Replace odo delete component integration with unit tests Jun 16, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 16, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

NoCluster Tests on commit 63b2329 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 63b2329 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

Unit Tests on commit 63b2329 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the unit-tests/odo-delete-component-main branch from 63ef2f2 to 990aa83 Compare June 16, 2023 07:25
@feloy feloy temporarily deployed to external June 16, 2023 07:25 — with GitHub Actions Inactive
@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

Validate Tests on commit e937ef8 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

Kubernetes Tests on commit 63b2329 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

Windows Tests (OCP) on commit 63b2329 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

OpenShift Tests on commit 63b2329 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 803718a finished with errors.
View logs: TXT HTML

@rm3l rm3l added area/refactoring Issues or PRs related to code refactoring and removed kind/code-refactoring labels Jun 19, 2023
@feloy feloy force-pushed the unit-tests/odo-delete-component-main branch from 990aa83 to f233d25 Compare June 20, 2023 08:13
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy requested a review from rm3l June 20, 2023 09:25
@feloy feloy changed the title [wip] Replace odo delete component integration with unit tests Replace odo delete component integration with unit tests Jun 21, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 21, 2023
@rm3l rm3l added this to the v3.12.0 🚀 milestone Jun 21, 2023
rm3l
rm3l approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 21, 2023
@feloy
Copy link
Contributor Author

feloy commented Jun 21, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [423.619 seconds]
odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  [BeforeEach] /go/odo_1/tests/integration/cmd_dev_test.go:527
  [It] /go/odo_1/tests/integration/cmd_dev_test.go:544

[FAILED] [422.289 seconds]
odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  [BeforeEach] /go/odo_1/tests/integration/cmd_dev_test.go:2185
  [It] /go/odo_1/tests/integration/cmd_dev_test.go:2210

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [423.619 seconds]
odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
 [BeforeEach] /go/odo_1/tests/integration/cmd_dev_test.go:527
 [It] /go/odo_1/tests/integration/cmd_dev_test.go:544

[FAILED] [422.289 seconds]
odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 [BeforeEach] /go/odo_1/tests/integration/cmd_dev_test.go:2185
 [It] /go/odo_1/tests/integration/cmd_dev_test.go:2210

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jun 21, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [181.794 seconds]
odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-k8s) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
/go/odo_1/tests/integration/cmd_remove_binding_test.go:71

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

[FAILED] [181.794 seconds]
odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-k8s) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
/go/odo_1/tests/integration/cmd_remove_binding_test.go:71

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jun 21, 2023

/override windows-integration-test/Windows-test

 [FAILED] [102.501 seconds]
odo describe/list binding command tests when creating a component with a binding as environment variables (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace [It] should list the binding with --namespace flag - command: [list binding]
C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_describe_list_binding_test.go:810

[FAILED] [213.386 seconds]
odo dev command tests 1. devfile contains composite apply command when odo dev is running with image build extra args [It] should execute the composite apply commands successfully
C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_dev_test.go:2320

odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [BeforeEach] should mount the volumes
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_dev_test.go:759

[FAILED] [247.804 seconds]
odo list with devfile devfile has missing metadata when projectType is missing when the component is pushed in dev mode [BeforeEach] should show the language for 'Type' in odo list
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_devfile_list_test.go:324
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_devfile_list_test.go:334

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [102.501 seconds]
odo describe/list binding command tests when creating a component with a binding as environment variables (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace [It] should list the binding with --namespace flag - command: [list binding]
C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_describe_list_binding_test.go:810

[FAILED] [213.386 seconds]
odo dev command tests 1. devfile contains composite apply command when odo dev is running with image build extra args [It] should execute the composite apply commands successfully
C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_dev_test.go:2320

odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [BeforeEach] should mount the volumes
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_dev_test.go:759

[FAILED] [247.804 seconds]
odo list with devfile devfile has missing metadata when projectType is missing when the component is pushed in dev mode [BeforeEach] should show the language for 'Type' in odo list
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_devfile_list_test.go:324
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4194/tests/integration/cmd_devfile_list_test.go:334

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a292535 into redhat-developer:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
area/refactoring Issues or PRs related to code refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.12.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@feloy @rm3l @openshift-merge-robot