Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return an error in odo analyze if current directory contains an invalid Devfile #6905

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 16, 2023

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6683

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
See repro steps in #6683

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 16, 2023
@rm3l rm3l temporarily deployed to external June 16, 2023 07:16 — with GitHub Actions Inactive
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e93f48f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64932169a1184e000803ab9a

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 16, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

NoCluster Tests on commit f6f660e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

OpenShift Unauthenticated Tests on commit f6f660e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

Unit Tests on commit f6f660e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

Validate Tests on commit f6f660e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

Kubernetes Tests on commit f6f660e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

Windows Tests (OCP) on commit f6f660e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

OpenShift Tests on commit f6f660e finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 16, 2023

Kubernetes Docs Tests on commit a292535 finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6683-odo-analyze-returns-error-if-current-directory-contains-an-invalid-devfile branch from 0690737 to 3030379 Compare June 19, 2023 08:10
@rm3l rm3l changed the title Do not return an error in odo analyze if current directory contains an invalid Devfile [WIP] Do not return an error in odo analyze if current directory contains an invalid Devfile Jun 19, 2023
rm3l added 5 commits June 21, 2023 18:03
…valid Devfile

For the 'analyze' command, this is not required,
so Devfile parsing will be ignored completely.
Otherwise, some code will assume it is relative,
and try to prepend the current physical directory
@rm3l rm3l force-pushed the 6683-odo-analyze-returns-error-if-current-directory-contains-an-invalid-devfile branch from 3030379 to e93f48f Compare June 21, 2023 16:12
@rm3l rm3l changed the title [WIP] Do not return an error in odo analyze if current directory contains an invalid Devfile Do not return an error in odo analyze if current directory contains an invalid Devfile Jun 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l marked this pull request as ready for review June 21, 2023 19:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 21, 2023
@openshift-ci openshift-ci bot requested review from kadel and valaparthvi June 21, 2023 19:37
@rm3l rm3l requested review from feloy and removed request for kadel June 21, 2023 19:37
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 22, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 22, 2023

  [FAILED] Timed out after 420.001s.
  Expected
      <string>:   __
       /  \__     Developing using the "rrnylj" Devfile
       \__/  \    Namespace: cmd-dev-test600thr
       /  \__/    odo version: v3.11.0
       \__/
      
      ↪ Running on the cluster in Dev mode
       •  Waiting for Kubernetes resources  ...
       âš   Pod is Pending
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   AttachVolume.Attach failed for volume "pvc-87a9ce7b-78c7-4e7d-8f3e-8c126760999b" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-88fdbb0d-b379-4830-a20d-e203d8cb55cb
       âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-shared-data kube-api-access-dnh85 odo-projects]: timed out waiting for the condition
       âš   AttachVolume.Attach failed for volume "pvc-87a9ce7b-78c7-4e7d-8f3e-8c126760999b" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-88fdbb0d-b379-4830-a20d-e203d8cb55cb
       âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-dnh85]: timed out waiting for the condition
       âš   AttachVolume.Attach failed for volume "pvc-87a9ce7b-78c7-4e7d-8f3e-8c126760999b" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-88fdbb0d-b379-4830-a20d-e203d8cb55cb
      
  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 06/21/23 20:51:16.584
...
Summarizing 1 Failure:
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54

Ran 475 of 918 Specs in 1633.089 seconds
FAIL! -- 474 Passed | 1 Failed | 0 Pending | 443 Skipped

Storage issues on OpenShift - reported in #6894

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

 [FAILED] Timed out after 420.001s.
 Expected
     <string>:   __
      /  \__     Developing using the "rrnylj" Devfile
      \__/  \    Namespace: cmd-dev-test600thr
      /  \__/    odo version: v3.11.0
      \__/
     
     ↪ Running on the cluster in Dev mode
      •  Waiting for Kubernetes resources  ...
      âš   Pod is Pending
      âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      âš   AttachVolume.Attach failed for volume "pvc-87a9ce7b-78c7-4e7d-8f3e-8c126760999b" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-88fdbb0d-b379-4830-a20d-e203d8cb55cb
      âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-shared-data kube-api-access-dnh85 odo-projects]: timed out waiting for the condition
      âš   AttachVolume.Attach failed for volume "pvc-87a9ce7b-78c7-4e7d-8f3e-8c126760999b" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-88fdbb0d-b379-4830-a20d-e203d8cb55cb
      âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-dnh85]: timed out waiting for the condition
      âš   AttachVolume.Attach failed for volume "pvc-87a9ce7b-78c7-4e7d-8f3e-8c126760999b" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-88fdbb0d-b379-4830-a20d-e203d8cb55cb
     
 to contain substring
     <string>: [Ctrl+c] - Exit
 In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 06/21/23 20:51:16.584
...
Summarizing 1 Failure:
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54

Ran 475 of 918 Specs in 1633.089 seconds
FAIL! -- 474 Passed | 1 Failed | 0 Pending | 443 Skipped

Storage issues on OpenShift - reported in #6894

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jun 22, 2023

  [FAILED] Timed out after 420.012s.
  Expected
      <string>:   __
       /  \__     Developing using the "mmwtez" Devfile
       \__/  \    Namespace: cmd-dev-test804mwc
       /  \__/    odo version: v3.11.0
       \__/
      
      - Running on the cluster in Dev mode
       -  Waiting for Kubernetes resources  ...
       !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       !  Pod is Pending
       !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       !  AttachVolume.Attach failed for volume "pvc-8df539bb-0904-43c1-930c-b99a766616af" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cd42c6c9-6e7b-4d3a-88a6-29444ea32fd3
       !  AttachVolume.Attach failed for volume "pvc-c6e0c891-5251-4abf-84dc-298f7ada8405" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-302bd738-ecfa-492e-89ee-05882a815272
       !  AttachVolume.Attach failed for volume "pvc-7f697659-8dde-4386-a2f8-f4f1f686ca79" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-eb0a1eab-cd3a-4527-a37a-3c607e251ec7
       !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc auto-pvc-automount-mount-path-pvc], unattached volumes=[auto-cm-automount-mount-path-configmap auto-secret-automount-access-mode-secret auto-cm-automount-default-configmap auto-secret-automount-mount-path-secret auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc auto-secret-automount-access-mode-subpath-secret auto-cm-automount-access-mode-configmap-decimal auto-cm-automount-subpath-configmap auto-cm-automount-access-mode-configmap auto-secret-automount-default-secret odo-projects auto-cm-automount-access-mode-subpath-configmap kube-api-access-qkh7p odo-shared-data auto-secret-automount-subpath-secret auto-pvc-automount-mount-path-pvc]: timed out waiting for the condition
       !  AttachVolume.Attach failed for volume "pvc-8df539bb-0904-43c1-930c-b99a766616af" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cd42c6c9-6e7b-4d3a-88a6-29444ea32fd3
       !  AttachVolume.Attach failed for volume "pvc-c6e0c891-5251-4abf-84dc-298f7ada8405" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-302bd738-ecfa-492e-89ee-05882a815272
       !  AttachVolume.Attach failed for volume "pvc-7f697659-8dde-4386-a2f8-f4f1f686ca79" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-eb0a1eab-cd3a-4527-a37a-3c607e251ec7
       !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-mount-path-pvc auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc], unattached volumes=[auto-cm-automount-default-configmap auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret auto-cm-automount-subpath-configmap odo-shared-data auto-pvc-automount-mount-path-pvc auto-secret-automount-subpath-secret auto-pvc-automount-readonly-pvc auto-secret-automount-mount-path-secret auto-cm-automount-access-mode-configmap auto-pvc-automount-default-pvc auto-cm-automount-mount-path-configmap kube-api-access-qkh7p auto-secret-automount-access-mode-secret odo-projects auto-secret-automount-access-mode-subpath-secret auto-cm-automount-access-mode-subpath-configmap]: timed out waiting for the condition
       !  AttachVolume.Attach failed for volume "pvc-8df539bb-0904-43c1-930c-b99a766616af" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cd42c6c9-6e7b-4d3a-88a6-29444ea32fd3
       !  AttachVolume.Attach failed for volume "pvc-7f697659-8dde-4386-a2f8-f4f1f686ca79" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-eb...

  Gomega truncated this representation as it exceeds 'format.MaxLength'.
  Consider having the object provide a custom 'GomegaStringer' representation
  or adjust the parameters in Gomega's 'format' package.

  Learn more here: https://onsi.github.io/gomega/#adjusting-output

  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_run.go:54 @ 06/21/23 13:50:13.872
...

Summarizing 3 Failures:
  [FAIL] odo dev command tests multiple dev sessions with different project are running on same platform (podman=false), same port when odo dev session is run for nodejs component when odo dev session is run for go project on the same port but different address when go and nodejs files are modified [It] should be possible to access both the projects on same address and port
  C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_http.go:52
  [FAIL] odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [BeforeEach] should mount the volumes
  C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_run.go:54
  [FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes
  C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_cmd_wrapper.go:120

Ran 459 of 918 Specs in 2037.576 seconds
FAIL! -- 456 Passed | 3 Failed | 0 Pending | 459 Skipped

Storage issues on OpenShift - reported in #6894

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

 [FAILED] Timed out after 420.012s.
 Expected
     <string>:   __
      /  \__     Developing using the "mmwtez" Devfile
      \__/  \    Namespace: cmd-dev-test804mwc
      /  \__/    odo version: v3.11.0
      \__/
     
     - Running on the cluster in Dev mode
      -  Waiting for Kubernetes resources  ...
      !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      !  Pod is Pending
      !  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      !  AttachVolume.Attach failed for volume "pvc-8df539bb-0904-43c1-930c-b99a766616af" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cd42c6c9-6e7b-4d3a-88a6-29444ea32fd3
      !  AttachVolume.Attach failed for volume "pvc-c6e0c891-5251-4abf-84dc-298f7ada8405" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-302bd738-ecfa-492e-89ee-05882a815272
      !  AttachVolume.Attach failed for volume "pvc-7f697659-8dde-4386-a2f8-f4f1f686ca79" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-eb0a1eab-cd3a-4527-a37a-3c607e251ec7
      !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc auto-pvc-automount-mount-path-pvc], unattached volumes=[auto-cm-automount-mount-path-configmap auto-secret-automount-access-mode-secret auto-cm-automount-default-configmap auto-secret-automount-mount-path-secret auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc auto-secret-automount-access-mode-subpath-secret auto-cm-automount-access-mode-configmap-decimal auto-cm-automount-subpath-configmap auto-cm-automount-access-mode-configmap auto-secret-automount-default-secret odo-projects auto-cm-automount-access-mode-subpath-configmap kube-api-access-qkh7p odo-shared-data auto-secret-automount-subpath-secret auto-pvc-automount-mount-path-pvc]: timed out waiting for the condition
      !  AttachVolume.Attach failed for volume "pvc-8df539bb-0904-43c1-930c-b99a766616af" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cd42c6c9-6e7b-4d3a-88a6-29444ea32fd3
      !  AttachVolume.Attach failed for volume "pvc-c6e0c891-5251-4abf-84dc-298f7ada8405" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-302bd738-ecfa-492e-89ee-05882a815272
      !  AttachVolume.Attach failed for volume "pvc-7f697659-8dde-4386-a2f8-f4f1f686ca79" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-eb0a1eab-cd3a-4527-a37a-3c607e251ec7
      !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-mount-path-pvc auto-pvc-automount-readonly-pvc auto-pvc-automount-default-pvc], unattached volumes=[auto-cm-automount-default-configmap auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret auto-cm-automount-subpath-configmap odo-shared-data auto-pvc-automount-mount-path-pvc auto-secret-automount-subpath-secret auto-pvc-automount-readonly-pvc auto-secret-automount-mount-path-secret auto-cm-automount-access-mode-configmap auto-pvc-automount-default-pvc auto-cm-automount-mount-path-configmap kube-api-access-qkh7p auto-secret-automount-access-mode-secret odo-projects auto-secret-automount-access-mode-subpath-secret auto-cm-automount-access-mode-subpath-configmap]: timed out waiting for the condition
      !  AttachVolume.Attach failed for volume "pvc-8df539bb-0904-43c1-930c-b99a766616af" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-cd42c6c9-6e7b-4d3a-88a6-29444ea32fd3
      !  AttachVolume.Attach failed for volume "pvc-7f697659-8dde-4386-a2f8-f4f1f686ca79" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-eb...

 Gomega truncated this representation as it exceeds 'format.MaxLength'.
 Consider having the object provide a custom 'GomegaStringer' representation
 or adjust the parameters in Gomega's 'format' package.

 Learn more here: https://onsi.github.io/gomega/#adjusting-output

 to contain substring
     <string>: [Ctrl+c] - Exit
 In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_run.go:54 @ 06/21/23 13:50:13.872
...

Summarizing 3 Failures:
 [FAIL] odo dev command tests multiple dev sessions with different project are running on same platform (podman=false), same port when odo dev session is run for nodejs component when odo dev session is run for go project on the same port but different address when go and nodejs files are modified [It] should be possible to access both the projects on same address and port
 C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_http.go:52
 [FAIL] odo dev command tests when a component is bootstrapped when Automount volumes are present in the namespace when odo dev is executed [BeforeEach] should mount the volumes
 C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_run.go:54
 [FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes
 C:/Users/Administrator.ANSIBLE-TEST-VS/4213/tests/helper/helper_cmd_wrapper.go:120

Ran 459 of 918 Specs in 2037.576 seconds
FAIL! -- 456 Passed | 3 Failed | 0 Pending | 459 Skipped

Storage issues on OpenShift - reported in #6894

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 28ed064 into redhat-developer:main Jun 22, 2023
@rm3l rm3l mentioned this pull request Sep 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo analyze returns error if current directory contains an invalid Devfile
3 participants