-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return an error in odo analyze
if current directory contains an invalid Devfile
#6905
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
0690737
to
3030379
Compare
odo analyze
if current directory contains an invalid Devfileodo analyze
if current directory contains an invalid Devfile
…valid Devfile For the 'analyze' command, this is not required, so Devfile parsing will be ignored completely.
Otherwise, some code will assume it is relative, and try to prepend the current physical directory
3030379
to
e93f48f
Compare
odo analyze
if current directory contains an invalid Devfileodo analyze
if current directory contains an invalid Devfile
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Storage issues on OpenShift - reported in #6894 /override OpenShift-Integration-tests/OpenShift-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Storage issues on OpenShift - reported in #6894 /override windows-integration-test/Windows-test |
@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6683
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See repro steps in #6683