Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable service binding related integration tests #6920

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 21, 2023

What type of PR is this:

/area testing

The purpose of this PR is to test the impact of removing the integration tests related to service binding.

It introduces an SKIP_SERVICE_BINDING_TESTS environment variable which indidate to skip tests related to service binding.

This variable has been set to true for Kubernetes, OpenShift and Windows tests on IBM Cloud, to disable these tests for PRs.

The tests will still run during the nightly tests.

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jun 21, 2023
@feloy feloy requested review from kadel, rm3l and valaparthvi June 21, 2023 14:13
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 2f4f886
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6495a416c434350009817f59

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

OpenShift Unauthenticated Tests on commit bf0b4ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

NoCluster Tests on commit bf0b4ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

Unit Tests on commit bf0b4ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

Validate Tests on commit bf0b4ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

Windows Tests (OCP) on commit bf0b4ed finished successfully.
View logs: TXT HTML

@feloy feloy changed the title Disable service binding related integration tests [wip] Disable service binding related integration tests Jun 21, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 21, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

Kubernetes Tests on commit bf0b4ed finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

Kubernetes Docs Tests on commit d9d868f finished with errors.
View logs: TXT HTML

@feloy feloy force-pushed the tests/disable-service-binding-tests branch from 96ed9dd to fe64a6b Compare June 21, 2023 15:45
@odo-robot
Copy link

odo-robot bot commented Jun 21, 2023

OpenShift Tests on commit bf0b4ed finished successfully.
View logs: TXT HTML

@feloy feloy closed this Jun 22, 2023
@feloy feloy reopened this Jun 22, 2023
@feloy feloy force-pushed the tests/disable-service-binding-tests branch 2 times, most recently from 384747a to adfa975 Compare June 22, 2023 08:56
@feloy feloy changed the title [wip] Disable service binding related integration tests Disable service binding related integration tests Jun 22, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 22, 2023
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e_test.go:Context("starting with non-empty Directory add Binding", func() {
can use skipping.

Also, wouldn't you need to modify IBM pipelines to export the env var? I believe the tests are still run on OpenShift, since I do not see any difference between the number of k8s and oc tests.

@feloy
Copy link
Contributor Author

feloy commented Jun 22, 2023

e2e_test.go:Context("starting with non-empty Directory add Binding", func() { can use skipping.

No, I would like to keep the tests for e2e tests.

@valaparthvi
Copy link
Contributor

Also, wouldn't you need to modify IBM pipelines to export the env var? I believe the tests are still run on OpenShift, since I do not see any difference between the number of k8s and oc tests.

In case you missed.

@feloy
Copy link
Contributor Author

feloy commented Jun 22, 2023

Also, wouldn't you need to modify IBM pipelines to export the env var? I believe the tests are still run on OpenShift, since I do not see any difference between the number of k8s and oc tests.

In case you missed.

I defined the env var in the pipelines, but after the job has been created. It seems the env variables are considered at the time the job is created (not the time it is started).

Let me try again

@feloy feloy closed this Jun 22, 2023
@feloy feloy reopened this Jun 22, 2023
@feloy feloy closed this Jun 22, 2023
@feloy feloy reopened this Jun 22, 2023
@feloy feloy force-pushed the tests/disable-service-binding-tests branch from bcc1080 to 2f4f886 Compare June 23, 2023 13:54
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added this to the v3.12.0 🚀 milestone Jun 23, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 23, 2023
@feloy
Copy link
Contributor Author

feloy commented Jun 23, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

[FAILED] [74.869 seconds]
User guides: Quickstart test Java quickstart guide [It] should test the complete java springboot quickstart output in order
/go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:217

  [odo]  âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

[FAILED] [74.869 seconds]
User guides: Quickstart test Java quickstart guide [It] should test the complete java springboot quickstart output in order
/go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:217

 [odo]  âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ae28de1 into redhat-developer:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants