-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable service binding related integration tests #6920
Disable service binding related integration tests #6920
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
96ed9dd
to
fe64a6b
Compare
384747a
to
adfa975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e_test.go:Context("starting with non-empty Directory add Binding", func() {
can use skipping.
Also, wouldn't you need to modify IBM pipelines to export the env var? I believe the tests are still run on OpenShift, since I do not see any difference between the number of k8s and oc tests.
No, I would like to keep the tests for e2e tests. |
In case you missed. |
I defined the env var in the pipelines, but after the job has been created. It seems the env variables are considered at the time the job is created (not the time it is started). Let me try again |
bcc1080
to
2f4f886
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
|
@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/area testing
The purpose of this PR is to test the impact of removing the integration tests related to service binding.
It introduces an
SKIP_SERVICE_BINDING_TESTS
environment variable which indidate to skip tests related to service binding.This variable has been set to
true
for Kubernetes, OpenShift and Windows tests on IBM Cloud, to disable these tests for PRs.The tests will still run during the nightly tests.