Fix potential issue in odo version nightly tests if user does not have permission to get the OpenShift version
#6933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penShift platform version This happened on the nightly jobs running on Prow, which makes us use a developer account with some restrictions.
… the intent clearer
openshift-ci
bot
added
kind/bug
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
rm3l
changed the title
odo version tests if user does not have permission to get the OpenShift versionodo version tests if user does not have permission to get the OpenShift version
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
changed the title
odo version tests if user does not have permission to get the OpenShift versionodo version nightly tests if user does not have permission to get the OpenShift version
openshift-ci
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/area testing
What does this PR do / why we need it:
This fixes a potential issue with the
odo versionintegration tests, which failed in the nightly jobs (running on Prow) because thedeveloperuser does not have the permissions to get the OpenShift version.Based on what had been done in #6551 to fix a similar issue, it gets the version from
oc versionand if something is reported about the server, will check thatodo versiondisplays the right information about OpenShift. If not, then such information should be missing from theodo versionoutput.Which issue(s) this PR fixes:
Normal users have no way to get the OpenShift versionPR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: