Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display list of commands from the local devfile in odo describe component output #6944

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 30, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:
This adds information about commands defined in the Devfile fro; the odo describe component output.

Which issue(s) this PR fixes:
Fixes #6892

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
See #6892 for more context. When executed from a directory containing a Devfile, odo describe component should now display the list of commands that are defined in the Devfile, if any.
In the JSON output, this is available under a new .devfileData.commands field.

odo describe component -o json | jq -r '.devfileData.commands'
[                                                                                                                                                                                              
  {                                                                                                                                                                                            
    "name": "install",                                                                                                                                                                         
    "type": "exec",                                                                                                                                                                            
    "group": "build",                                                                                                                                                                          
    "isDefault": true,                                                                                                                                                                         
    "commandLine": "npm install",                                                                                                                                                              
    "component": "runtime",                                                                                                                                                                    
    "componentType": "container"                                                                                                                                                               
  },                                                                                                                                                                                           
  {                                                                                                                                                                                            
    "name": "innerloop-pod-command",                                                                                                                                                           
    "type": "apply",                                                                                                                                                                           
    "group": "test",                                                                                                                                                                           
    "isDefault": false,                                                                                                                                                                        
    "component": "innerloop-pod",                                                                                                                                                              
    "componentType": "kubernetes"                                                                                                                                                              
  },                                                                                                                                                                                           
  {                                                                                                                                                                                            
    "name": "start",                                                                                                                                                                           
    "type": "exec",                                                                                                                                                                            
    "commandLine": "npm start",                                                                                                                                                                
    "component": "runtime",                                                                                                                                                                    
    "componentType": "container"                                                                                                                                                               
  },
  {
    "name": "run",
    "type": "composite",
    "group": "run",
    "isDefault": true
  },
  {
    "name": "build-image",
    "type": "apply",
    "component": "prod-image",
    "componentType": "image",
    "imageName": "quay.io/tkral/devfile-nodejs-deploy:latest"
  },
  {
    "name": "deploy-deployment",
    "type": "apply",
    "component": "outerloop-deploy",
    "componentType": "kubernetes"
  },
  {
    "name": "deploy-another-deployment",
    "type": "apply",
    "component": "another-deployment",
    "componentType": "kubernetes"
  },
  {
    "name": "outerloop-pod-command",
    "type": "apply",
    "component": "outerloop-pod",
    "componentType": "kubernetes"
  },
  {
    "name": "deploy",
    "type": "composite",
    "group": "deploy",
    "isDefault": true
  }
]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rm3l rm3l temporarily deployed to internal June 30, 2023 16:09 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 30, 2023
@netlify
Copy link

netlify bot commented Jun 30, 2023

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit be0a706
😎 Deploy Preview https://odo-dev-pr-6944.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Jun 30, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

Windows Tests (OCP) on commit 37e6ded finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

OpenShift Unauthenticated Tests on commit 37e6ded finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

NoCluster Tests on commit 37e6ded finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

Unit Tests on commit 37e6ded finished successfully.
View logs: TXT HTML

@rm3l rm3l changed the title [WIP] Display list of commands from the local devfile in odo describe component output Display list of commands from the local devfile in odo describe component output Jun 30, 2023
@rm3l rm3l marked this pull request as ready for review June 30, 2023 16:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 30, 2023
@rm3l rm3l temporarily deployed to internal June 30, 2023 16:19 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy June 30, 2023 16:19
@rm3l rm3l removed the request for review from anandrkskd June 30, 2023 16:20
@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

Validate Tests on commit 37e6ded finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

Kubernetes Tests on commit 37e6ded finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 30, 2023

Kubernetes Docs Tests on commit 97644aa finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 3, 2023
@rm3l rm3l closed this Jul 3, 2023
@rm3l rm3l reopened this Jul 3, 2023
@rm3l rm3l temporarily deployed to internal July 3, 2023 13:42 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-merge-robot openshift-merge-robot merged commit 4479c24 into redhat-developer:main Jul 3, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal July 3, 2023 14:19 — with GitHub Actions Inactive
@rm3l rm3l deleted the 6892-display-list-of-commands-from-the-local-devfile-in-odo-describe-component-output branch July 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display list of commands from the local devfile in odo describe component output
3 participants