Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /devfile PUT and GET endpoints #6950

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Add /devfile PUT and GET endpoints #6950

merged 8 commits into from
Jul 6, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 5, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6901

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Jul 5, 2023
@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit cf4ba44
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64a6daedba06c9000845b786

@openshift-ci openshift-ci bot requested review from kadel and rm3l July 5, 2023 12:13
@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Windows Tests (OCP) on commit 6bff870 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 6bff870 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

NoCluster Tests on commit 6bff870 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Unit Tests on commit 6bff870 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Validate Tests on commit 6bff870 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Kubernetes Tests on commit 6bff870 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

OpenShift Tests on commit 6bff870 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 5, 2023 •
edited
Loading

Kubernetes Docs Tests on commit c4b103d finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [wip] Add /devfile PUT and GET endpoints Add /devfile PUT and GET endpoints Jul 5, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 5, 2023
rm3l
rm3l reviewed Jul 6, 2023
View reviewed changes
pkg/apiserver-impl/api_default_service.go Outdated Show resolved Hide resolved
ui/src/app/api-gen/.openapi-generator/FILES Outdated Show resolved Hide resolved
@feloy feloy requested a review from rm3l July 6, 2023 12:19
@feloy feloy force-pushed the feature-6901/api-devfile-set-get branch from d753c4a to 4134fe2 Compare July 6, 2023 14:10
@feloy feloy force-pushed the feature-6901/api-devfile-set-get branch from c1bc954 to cf4ba44 Compare July 6, 2023 15:16
rm3l
rm3l approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 6, 2023
@feloy
Copy link
Contributor Author

feloy commented Jul 6, 2023

/override cypress-run

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

@feloy: Overrode contexts on behalf of feloy: cypress-run

In response to this:

/override cypress-run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor Author

feloy commented Jul 6, 2023

/override windows-integration-test/Windows-test

 [FAILED] [2.625 seconds]
odo create/delete/list/set namespace/project tests delete namespace when force-deleting a valid namespace [BeforeEach] should successfully delete the namespace asynchronously
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4341/tests/integration/cmd_namespace_test.go:74
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4341/tests/integration/cmd_namespace_test.go:96

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [2.625 seconds]
odo create/delete/list/set namespace/project tests delete namespace when force-deleting a valid namespace [BeforeEach] should successfully delete the namespace asynchronously
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4341/tests/integration/cmd_namespace_test.go:74
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4341/tests/integration/cmd_namespace_test.go:96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2c3d2ea into redhat-developer:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API endpoints to get and save the local Devfile
3 participants
@feloy @rm3l @openshift-merge-robot