-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup OWNERS files #6997
Merged
openshift-merge-robot
merged 1 commit into
redhat-developer:main
from
rm3l:cleanup_owners_files
Jul 21, 2023
Merged
Cleanup OWNERS files #6997
openshift-merge-robot
merged 1 commit into
redhat-developer:main
from
rm3l:cleanup_owners_files
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the list is accurate, to avoid requesting PR reviews from people no longer maintaining the project. Ideally, I would put a GitHub team, but this does not seem to be supported [1]. It can be done via an additional OWNERS_ALIASES file [2], but this is yet to be tested. [1] https://www.kubernetes.dev/docs/guide/owners/ [2] https://www.kubernetes.dev/docs/guide/owners/#owners_aliases
🔨 Deploy Preview deleted from internal cluster!
|
Kudos, SonarCloud Quality Gate passed! |
feloy
approved these changes
Jul 21, 2023
openshift-ci
bot
added
the
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
label
Jul 21, 2023
openshift-merge-robot
temporarily deployed
to
internal
July 21, 2023 12:27
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
What does this PR do / why we need it:
This makes sure the list is accurate, to avoid requesting PR reviews
from people no longer maintaining the project.
Ideally, I would put a GitHub team,
but this does not seem to be supported [1].
It can be done via an additional OWNERS_ALIASES file [2],
but this is yet to be tested.
[1] https://www.kubernetes.dev/docs/guide/owners/
[2] https://www.kubernetes.dev/docs/guide/owners/#owners_aliases
Which issue(s) this PR fixes:
—
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: