Fix podman version check #7010
Merged
Fix podman version check #7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
rm3l
reviewed
Aug 1, 2023
rm3l
reviewed
Aug 1, 2023
rm3l
approved these changes
Aug 1, 2023
openshift-ci
bot
added
the
lgtm
rm3l
added
area/odo-on-podman
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
There was a problem with the previous implementation; cmd.Wait() and reading the stdout pipe were executed in parallel, but because cmd.Wait() closes the std pipes before to return, this can make the reading of the pipe fail.
Which issue(s) this PR fixes:
Fixes #6956
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: