Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubeconfig flag #7017

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Remove kubeconfig flag #7017

merged 4 commits into from
Aug 4, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 3, 2023 •
edited
Loading

What type of PR is this:

/kind bug

What does this PR do / why we need it:

  • --kubeconfig flag was introduced by mistake by using the library controller-runtime.
  • This PR removes the check of the KUBECONFIG value for odo list, as this value can be a list of files. The check of the KUBECONFIG value is done by the clientcmd library used to get the Kubernetes config

Which issue(s) this PR fixes:

Fixes #5732
Fixes #6700

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 3, 2023
@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit e51734c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64ccc1819f1816000878cfc0
😎 Deploy Preview https://deploy-preview-7017--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot requested review from kadel and rm3l August 3, 2023 09:58
@feloy
Do not check file exists from KUBECONFIG, as KUBECONFIG can be a list…
54c6583 
… of files and this is done by clientcmd library
@feloy feloy changed the title Remove kubeconfig flag [wip] Remove kubeconfig flag Aug 3, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 3, 2023
@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Windows Tests (OCP) on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

NoCluster Tests on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Unit Tests on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Validate Tests on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Kubernetes Tests on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

OpenShift Tests on commit 5aa2c44 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 3, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 1c6767e finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member

rm3l commented Aug 3, 2023

This PR removes the check of the KUBECONFIG value for odo list, as this value can be a list of files. The check of the KUBECONFIG value is done by the clientcmd library used to get the Kubernetes config

So I guess this should also fix #6700, right?

@feloy feloy changed the title [wip] Remove kubeconfig flag Remove kubeconfig flag Aug 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 3, 2023
rm3l
rm3l reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a user-facing issue that can potentially confuse them, can we add a test to check that the --kubeconfig flag is no longer exposed?

@feloy feloy requested a review from rm3l August 4, 2023 09:14
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

rm3l
rm3l approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7c976f1 into redhat-developer:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
3 participants
@feloy @rm3l @openshift-merge-robot