Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update home page preview video with support of Podman #7023

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Update home page preview video with support of Podman #7023

merged 2 commits into from
Aug 4, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Aug 4, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Aug 4, 2023
@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 8121f40
😎 Deploy Preview https://odo-dev-pr-7023.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@rm3l rm3l temporarily deployed to internal August 4, 2023 10:23 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested review from feloy and kadel August 4, 2023 10:24
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Aug 4, 2023

Kubernetes Docs Tests on commit 7c976f1 finished successfully.
View logs: TXT HTML

feloy
feloy approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6e3a85f into redhat-developer:main Aug 4, 2023
7 checks passed
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal August 4, 2023 12:41 — with GitHub Actions Inactive
@rm3l rm3l modified the milestone: v3.14.0 🚀 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@feloy feloy

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
3 participants
@rm3l @feloy @openshift-merge-robot