Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Edit volumes #7061

Merged
merged 4 commits into from
Aug 31, 2023
Merged

[ui] Edit volumes #7061

merged 4 commits into from
Aug 31, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 30, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7058

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Aug 30, 2023
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 2d674f5
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64ef3592677b030008432ee3

@openshift-ci openshift-ci bot requested review from kadel and rm3l August 30, 2023 08:59
@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit fcb7eb0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

NoCluster Tests on commit fcb7eb0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

Unit Tests on commit fcb7eb0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

Validate Tests on commit fcb7eb0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

Windows Tests (OCP) on commit fcb7eb0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

Kubernetes Tests on commit fcb7eb0 finished successfully.
View logs: TXT HTML

@feloy feloy marked this pull request as draft August 30, 2023 09:27
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 30, 2023
@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

OpenShift Tests on commit fcb7eb0 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 30, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 9089f9a finished successfully.
View logs: TXT HTML

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy marked this pull request as ready for review August 30, 2023 20:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 30, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 31, 2023
@rm3l rm3l added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Aug 31, 2023
@rm3l
Copy link
Member

rm3l commented Aug 31, 2023 

[FAILED] Expected
      <string>: ACTIVE     NAME
                 calico-system
                 cmd-delete-test128cbc
                 cmd-delete-test128grr
                 cmd-delete-test151hxp
                 cmd-delete-test471hlc
                 cmd-delete-test471yfj
                 cmd-describe-component-test463vyt
                 cmd-describe-component-test626ipk
                 cmd-describe-component-test626rkb
                 cmd-dev-api-server-test239wps
                 cmd-dev-debug-test225jvm
                 cmd-dev-debug-test631aai
                 cmd-dev-test1207xbm
                 cmd-dev-test182mzb
                 cmd-dev-test2167avx
                 cmd-dev-test3553wvp
                 cmd-dev-test3788roc
                 cmd-dev-test507fit
                 cmd-dev-test577uuy
                 cmd-namespace-test41vjm
                 default
                 ibm-cert-store
                 ibm-odf-validation-webhook
                 ibm-system
                 kube-node-lease
                 kube-public
                 kube-system
                 laxu-namespace
                 openshift
                 openshift-apiserver
                 openshift-apiserver-operator
                 openshift-authentication
                 openshift-authentication-operator
                 openshift-cloud-credential-operator
                 openshift-cloud-network-config-controller
                 openshift-cluster-csi-drivers
                 openshift-cluster-machine-approver
                 openshift-cluster-node-tuning-operator
                 openshift-cluster-samples-operator
                 openshift-cluster-storage-operator
                 openshift-cluster-version
                 openshift-config
                 openshift-config-managed
                 openshift-config-operator
                 openshift-console
                 openshift-console-operator
                 openshift-console-user-settings
                 openshift-controller-manager
                 openshift-controller-manager-operator
                 openshift-dns
                 openshift-dns-operator
                 openshift-etcd
                 openshift-etcd-operator
                 openshift-image-registry
                 openshift-infra
                 openshift-ingress
                 openshift-ingress-canary
                 openshift-ingress-operator
                 openshift-insights
                 openshift-kube-apiserver
                 openshift-kube-apiserver-operator
                 openshift-kube-controller-manager
                 openshift-kube-controller-manager-operator
                 openshift-kube-proxy
                 openshift-kube-scheduler
                 openshift-kube-scheduler-operator
                 openshift-kube-storage-version-migrator
                 openshift-kube-storage-version-migrator-operator
                 openshift-machine-api
                 openshift-machine-config-operator
                 openshift-marketplace
                 openshift-monitoring
                 openshift-multus
                 openshift-network-diagnostics
                 openshift-network-operator
                 openshift-node
                 openshift-operator-lifecycle-manager
                 openshift-operators
                 openshift-roks-metrics
                 openshift-route-controller-manager
                 openshift-service-ca
                 openshift-service-ca-operator
                 openshift-user-workload-monitoring
                 tigera-operator
                 ubkm-project
      
  to contain substring
      <string>: cmd-namespace-test41usi
  In [It] at: /go/odo_1/tests/integration/cmd_namespace_test.go:43 @ 08/30/23 14:25:34.379
[...]

Summarizing 1 Failure:
  [FAIL] odo create/delete/list/set namespace/project tests when namespace is created with -w [It] should list the new namespace when listing namespace
  /go/odo_1/tests/integration/cmd_namespace_test.go:43

Ran 404 of 954 Specs in 1487.338 seconds
FAIL! -- 403 Passed | 1 Failed | 0 Pending | 550 Skipped

Flaky test - reported in #6966

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

[FAILED] Expected
     <string>: ACTIVE     NAME
                calico-system
                cmd-delete-test128cbc
                cmd-delete-test128grr
                cmd-delete-test151hxp
                cmd-delete-test471hlc
                cmd-delete-test471yfj
                cmd-describe-component-test463vyt
                cmd-describe-component-test626ipk
                cmd-describe-component-test626rkb
                cmd-dev-api-server-test239wps
                cmd-dev-debug-test225jvm
                cmd-dev-debug-test631aai
                cmd-dev-test1207xbm
                cmd-dev-test182mzb
                cmd-dev-test2167avx
                cmd-dev-test3553wvp
                cmd-dev-test3788roc
                cmd-dev-test507fit
                cmd-dev-test577uuy
                cmd-namespace-test41vjm
                default
                ibm-cert-store
                ibm-odf-validation-webhook
                ibm-system
                kube-node-lease
                kube-public
                kube-system
                laxu-namespace
                openshift
                openshift-apiserver
                openshift-apiserver-operator
                openshift-authentication
                openshift-authentication-operator
                openshift-cloud-credential-operator
                openshift-cloud-network-config-controller
                openshift-cluster-csi-drivers
                openshift-cluster-machine-approver
                openshift-cluster-node-tuning-operator
                openshift-cluster-samples-operator
                openshift-cluster-storage-operator
                openshift-cluster-version
                openshift-config
                openshift-config-managed
                openshift-config-operator
                openshift-console
                openshift-console-operator
                openshift-console-user-settings
                openshift-controller-manager
                openshift-controller-manager-operator
                openshift-dns
                openshift-dns-operator
                openshift-etcd
                openshift-etcd-operator
                openshift-image-registry
                openshift-infra
                openshift-ingress
                openshift-ingress-canary
                openshift-ingress-operator
                openshift-insights
                openshift-kube-apiserver
                openshift-kube-apiserver-operator
                openshift-kube-controller-manager
                openshift-kube-controller-manager-operator
                openshift-kube-proxy
                openshift-kube-scheduler
                openshift-kube-scheduler-operator
                openshift-kube-storage-version-migrator
                openshift-kube-storage-version-migrator-operator
                openshift-machine-api
                openshift-machine-config-operator
                openshift-marketplace
                openshift-monitoring
                openshift-multus
                openshift-network-diagnostics
                openshift-network-operator
                openshift-node
                openshift-operator-lifecycle-manager
                openshift-operators
                openshift-roks-metrics
                openshift-route-controller-manager
                openshift-service-ca
                openshift-service-ca-operator
                openshift-user-workload-monitoring
                tigera-operator
                ubkm-project
     
 to contain substring
     <string>: cmd-namespace-test41usi
 In [It] at: /go/odo_1/tests/integration/cmd_namespace_test.go:43 @ 08/30/23 14:25:34.379
[...]

Summarizing 1 Failure:
 [FAIL] odo create/delete/list/set namespace/project tests when namespace is created with -w [It] should list the new namespace when listing namespace
 /go/odo_1/tests/integration/cmd_namespace_test.go:43

Ran 404 of 954 Specs in 1487.338 seconds
FAIL! -- 403 Passed | 1 Failed | 0 Pending | 550 Skipped

Flaky test - reported in #6966

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7ff38b7 into redhat-developer:main Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Allow to edit Volumes from the Volumes Tab
3 participants
@feloy @rm3l @openshift-merge-robot