Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Edit images #7068

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Sep 4, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7056

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 4, 2023
@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 46a9102
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f5b469baa5710008557d4e

@openshift-ci openshift-ci bot requested review from kadel and rm3l September 4, 2023 09:33
@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Windows Tests (OCP) on commit 2f6ddec finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

OpenShift Unauthenticated Tests on commit 2f6ddec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

NoCluster Tests on commit 2f6ddec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Unit Tests on commit 2f6ddec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Validate Tests on commit 2f6ddec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Kubernetes Tests on commit 2f6ddec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

OpenShift Tests on commit 2f6ddec finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 4, 2023

Kubernetes Docs Tests on commit e65b4f6 finished successfully.
View logs: TXT HTML

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 4, 2023
@rm3l
Copy link
Member

rm3l commented Sep 4, 2023

/retest

@feloy
Copy link
Contributor Author

feloy commented Sep 4, 2023

/override windows-integration-test/Windows-test

[FAILED] [4.697 seconds]
odo create/delete/list/set namespace/project tests when namespace is created with -w [It] should list the new namespace when listing namespace
C:/Users/Administrator.ANSIBLE-TEST-VS/4544/tests/integration/cmd_namespace_test.go:41

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [4.697 seconds]
odo create/delete/list/set namespace/project tests when namespace is created with -w [It] should list the new namespace when listing namespace
C:/Users/Administrator.ANSIBLE-TEST-VS/4544/tests/integration/cmd_namespace_test.go:41

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8051843 into redhat-developer:main Sep 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Allow to edit Images from the Images Tab
3 participants