Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Edit container #7077

Merged
merged 5 commits into from
Sep 8, 2023
Merged

[ui] Edit container #7077

merged 5 commits into from
Sep 8, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Sep 7, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7053

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d408e8c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f9ef9ed26a550008f87939

@openshift-ci openshift-ci bot requested review from kadel and rm3l September 7, 2023 12:34
@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit da19a36 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

NoCluster Tests on commit da19a36 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

Unit Tests on commit da19a36 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

Validate Tests on commit da19a36 finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [ui] Edit container [wip] [ui] Edit container Sep 7, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 7, 2023
@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

Kubernetes Tests on commit da19a36 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

Windows Tests (OCP) on commit da19a36 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

OpenShift Tests on commit da19a36 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 7, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 56b868d finished successfully.
View logs: TXT HTML

@feloy feloy removed the request for review from kadel September 7, 2023 15:10
@feloy feloy force-pushed the feature-7053/edit-containers branch from 5dd850f to 73776c5 Compare September 7, 2023 15:22
@feloy feloy force-pushed the feature-7053/edit-containers branch from 73776c5 to d408e8c Compare September 7, 2023 15:43
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy changed the title [wip] [ui] Edit container [ui] Edit container Sep 7, 2023
@feloy feloy removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 7, 2023
@rm3l rm3l added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Sep 8, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1d96115 into redhat-developer:main Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Allow to edit Containers from the Containers Tab
3 participants
@feloy @rm3l @openshift-merge-robot