Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warning messages more visible #7097

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Sep 25, 2023

What type of PR is this:
/area UX
/kind bug

What does this PR do / why we need it:
For example, instead of displaying:

⚠  You are using "default" project, odo may not work as expected in the default project.

We are now displaying:

========================================================================================
⚠  You are using "default" project, odo may not work as expected in the default project.
========================================================================================

Which issue(s) this PR fixes:
Fixes #7071

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/UX Issues or PRs related to User Experience label Sep 25, 2023
@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 395b5fd
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/65119d93e782ff0008e33364
😎 Deploy Preview https://deploy-preview-7097--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2023
@openshift-ci openshift-ci bot requested review from feloy and kadel September 25, 2023 11:33
@rm3l rm3l force-pushed the 7071-ux-user-feedback-warning-messages-should-be-more-visible branch from a4d5615 to 838e8cf Compare September 25, 2023 11:33
@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

OpenShift Unauthenticated Tests on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

NoCluster Tests on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

Unit Tests on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

Validate Tests on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

Windows Tests (OCP) on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

Kubernetes Tests on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

OpenShift Tests on commit 431e65e finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 25, 2023

Kubernetes Docs Tests on commit 134a086 finished successfully.
View logs: TXT HTML

For example, instead of displaying:
```
⚠  You are using "default" project, odo may not work as expected in the default project.
```

We are now displaying:
```
========================================================================================
⚠  You are using "default" project, odo may not work as expected in the default project.
========================================================================================
```
@rm3l rm3l force-pushed the 7071-ux-user-feedback-warning-messages-should-be-more-visible branch from 838e8cf to 98a6554 Compare September 25, 2023 12:21
@rm3l rm3l temporarily deployed to internal September 25, 2023 12:21 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit d34fbae into redhat-developer:main Sep 26, 2023
4 checks passed
@rm3l rm3l deleted the 7071-ux-user-feedback-warning-messages-should-be-more-visible branch September 26, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UX Issues or PRs related to User Experience kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] [User Feedback] Warning messages should be more visible
3 participants