-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make warning messages more visible #7097
Merged
openshift-merge-robot
merged 6 commits into
redhat-developer:main
from
rm3l:7071-ux-user-feedback-warning-messages-should-be-more-visible
Sep 26, 2023
Merged
Make warning messages more visible #7097
openshift-merge-robot
merged 6 commits into
redhat-developer:main
from
rm3l:7071-ux-user-feedback-warning-messages-should-be-more-visible
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rm3l
force-pushed
the
7071-ux-user-feedback-warning-messages-should-be-more-visible
branch
from
September 25, 2023 11:33
a4d5615
to
838e8cf
Compare
For example, instead of displaying: ``` ⚠ You are using "default" project, odo may not work as expected in the default project. ``` We are now displaying: ``` ======================================================================================== ⚠ You are using "default" project, odo may not work as expected in the default project. ======================================================================================== ```
rm3l
force-pushed
the
7071-ux-user-feedback-warning-messages-should-be-more-visible
branch
from
September 25, 2023 12:21
838e8cf
to
98a6554
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
feloy
approved these changes
Sep 26, 2023
openshift-ci
bot
added
the
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
label
Sep 26, 2023
rm3l
deleted the
7071-ux-user-feedback-warning-messages-should-be-more-visible
branch
September 26, 2023 06:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/area UX
/kind bug
What does this PR do / why we need it:
For example, instead of displaying:
We are now displaying:
Which issue(s) this PR fixes:
Fixes #7071
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: