Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit CI to spin up clusters on-demand #7159

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Dec 6, 2023

  • [WIP] Add GH Workflow that spins up OCP cluster on IBM Cloud for each approved PR and tears it down after the job is done
  • Label ServiceBinding tests, so we can run them separately
  • Add GH Workflow for most of our tests (including cluster-related tests)
  • Drop unused code in helper_oc and use namespace instead of project

What type of PR is this:
/area infra
/area testing

What does this PR do / why we need it:
See #7144

Which issue(s) this PR fixes:
Fixes #7144

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. area/infra Issues or PRs related to setting up or fixing things in infrastructure. Mostly CI infrastructure. labels Dec 6, 2023
Copy link

openshift-ci bot commented Dec 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 85e561b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/65706941b08dd3000824975a

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Dec 6, 2023
Copy link

odo-robot bot commented Dec 6, 2023

NoCluster Tests on commit 205028e finished successfully.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

OpenShift Unauthenticated Tests on commit 205028e finished successfully.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

Unit Tests on commit 205028e finished successfully.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

Validate Tests on commit 205028e finished successfully.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

Kubernetes Tests on commit 205028e finished successfully.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

Windows Tests (OCP) on commit 205028e finished with errors.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

OpenShift Tests on commit 205028e finished successfully.
View logs: TXT HTML

Copy link

odo-robot bot commented Dec 6, 2023

Kubernetes Docs Tests on commit 86a9a2f finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 7144-reconfigure-ci-cluster-to-spin-up-clusters-on-demand branch from 78630c1 to 91c09c6 Compare December 6, 2023 09:49
They require installing additional components in the cluster (OLM, SBO, ...).
This allows to easily test even multiple versions of Kubernetes if needed.

For easier reporting and visualisation (and also avoid rebuilding odo many times),
Podman tests have also been relocated in this same Workflow.

Notes:
I tried to spin up lightweight OpenShift clusters but gave up because of several issues:
- MicroShift: I tried to use the aio container image, but this one is no longer maintained and is pretty old version of OCP.
Trying to follow the official guidelines did not work either because a base RHEL OS is mandatory
- CRC/OpenShiftLocal with Microshift preset: didnt pass the pre-checks because it detected an issue with nested virtualization on the GH Runner.
When testing on Microshift, it seems that the Project API is purposely not implemented on MicroShift
@rm3l rm3l force-pushed the 7144-reconfigure-ci-cluster-to-spin-up-clusters-on-demand branch from 91c09c6 to 85e561b Compare December 6, 2023 12:29
@rm3l rm3l changed the title [WIP] Revisit CI to spin up clusters on-demand Revisit CI to spin up clusters on-demand Dec 8, 2023
@rm3l rm3l marked this pull request as ready for review December 8, 2023 23:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 8, 2023
@openshift-ci openshift-ci bot requested a review from kadel December 8, 2023 23:10
@rm3l rm3l removed the request for review from kadel December 8, 2023 23:10
@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 8, 2023
@rm3l rm3l closed this Dec 8, 2023
@rm3l rm3l reopened this Dec 8, 2023
Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented Dec 8, 2023

/override openshift_tests

CI (Remote Clusters) Workflow disabled.

Copy link

openshift-ci bot commented Dec 8, 2023

@rm3l: Overrode contexts on behalf of rm3l: openshift_tests

In response to this:

/override openshift_tests

CI (Remote Clusters) Workflow disabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b5ea6f1 into redhat-developer:main Dec 8, 2023
44 of 45 checks passed
@rm3l rm3l deleted the 7144-reconfigure-ci-cluster-to-spin-up-clusters-on-demand branch December 8, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Issues or PRs related to setting up or fixing things in infrastructure. Mostly CI infrastructure. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconfigure CI cluster to spin up clusters on-demand
1 participant