add support for passing in input from STDIN #72
Conversation
pkg/cmd/convert.go
Outdated
| @@ -62,12 +63,22 @@ func GetValidatedObject(v *viper.Viper, cmd *cobra.Command, out, outerr io.Write | |||
| } | |||
|
|
|||
| var ocObjects []*object.OpenCompose | |||
| var data []byte | |||
There was a problem hiding this comment.
please move the declaration back to the loop where it was before. extending the scope is error prone
|
When I run $ opencompose convert -f -It remains stuck, is this behavior okay? |
|
@surajssd yep, this is the desired behavior, it is waiting for input. |
pkg/cmd/convert.go
Outdated
| return nil, fmt.Errorf("unable to read file '%s': %s", file, err) | ||
| // Check if the passed resource points to STDIN or not | ||
| if file == "-" { | ||
| data, err = ioutil.ReadAll(os.Stdin) |
There was a problem hiding this comment.
just curious: does cobra provide a way to read from STDIN ?
There was a problem hiding this comment.
@surajssd I didn't find any method in cobra regarding this, do you know something that can help?
|
How do we test this? |
But, I don't think that we should worry too much about testing this few lines. |
This commit lets passing input from STDIN to opencompose like in the following example - `cat example.yaml | opencompose -f -` An error will be returned if reading from STDIN fails. Fixes redhat-developer#63
kadel
dismissed
tnozicka’s stale review
'small nit' was fixed. and code looks ok
This commit lets passing input from STDIN to opencompose like in
the following example -
cat example.yaml | opencompose -f -An error will be returned if reading from STDIN fails.
Fixes #63
ping @tnozicka @surajssd @kadel