Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Javadoc on hover for property/method #452

Closed
angelozerr opened this issue Nov 26, 2021 · 1 comment · Fixed by #747
Closed

Display Javadoc on hover for property/method #452

angelozerr opened this issue Nov 26, 2021 · 1 comment · Fixed by #747
Assignees
@datho7561
Labels
hover qute template-file
Milestone
0.13.0

Comments

@angelozerr
Copy link
Contributor

Display Javadoc on hover for property/method. This get of javadoc should be done only when the hover require it (aka lazy loading) and not when JavaMethodIndo, JavaFiledInfo are getted to keep proper performance and avoid having memory problem.
@angelozerr
Copy link
Contributor Author

The main idea is to get the Javadoc only if we need and in this case get the Javadoc only for a givenmethod or field or class and stores it in

quarkus-ls/qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/commons/JavaElementInfo.java

Line 54 in 402a40c

return documentation;

It will require to implement a new JDT LS delegate command handler which should consume the new getJavadoc method in https://github.com/redhat-developer/quarkus-ls/blob/master/qute.jdt/com.redhat.qute.jdt/src/main/java/com/redhat/qute/jdt/QuteSupportForTemplate.java

@angelozerr angelozerr assigned datho7561 and unassigned AlexXuChen Aug 10, 2022
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Sep 22, 2022
@datho7561
Documentation when hovering object members in Qute
f4df8e7 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Sep 22, 2022
Merged
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Sep 22, 2022
@datho7561
Documentation when hovering object members in Qute
233f499 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Sep 28, 2022
@datho7561
Documentation when hovering object members in Qute
6809c13 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Sep 28, 2022
@datho7561
Documentation when hovering object members in Qute
5de34d0 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Sep 28, 2022
@datho7561
Documentation when hovering object members in Qute
4f742ff 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Sep 29, 2022
@datho7561
Documentation when hovering object members in Qute
b72986f 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Oct 4, 2022
@datho7561
Documentation when hovering object members in Qute
c89ce6d 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Oct 4, 2022
@datho7561
Documentation when hovering object members in Qute
d039c40 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/quarkus-ls that referenced this issue Oct 4, 2022
@datho7561
Documentation when hovering object members in Qute
d742a38 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes redhat-developer#452

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 5, 2022
@datho7561 @angelozerr
Documentation when hovering object members in Qute
ed5e29a 
eg.

The documentation for `java.lang.String.length()` will be shown when
hovering here:

```
{myString.len|gth()}
```

Closes #452

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.13.0 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
hover qute template-file
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Documentation when hovering object members in Qute datho7561/quarkus-ls
3 participants
@angelozerr @datho7561 @AlexXuChen