Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User tag snippet completion #784

Closed
angelozerr opened this issue Feb 1, 2023 · 0 comments · Fixed by #785
Closed

Improve User tag snippet completion #784

angelozerr opened this issue Feb 1, 2023 · 0 comments · Fixed by #785
Assignees
Labels
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Feb 1, 2023

Take a sample with #form renarde user tag which have this content:

<form action="{it}" method="{method ?: 'POST'}" {#if class??}class="{class}"{/if} {#if id??}id="{id}"{/if}>
 {#authenticityToken/}
 {nested-content}
</form>

In a Qute template, when completion is opened it provide #form and when completion is applied it generates:

{#form /}

although #form expects some HTML content like <input, it should generate

{#form it }

{/form}

and better replace it with all uri, uriabs.

To do that we need to load the user tag content and

  • check if there is {nested-content}
  • check if there is {it}

Another improvement which should be nice is to provide completion for parameters declared in user tag. Given this completion:

{#form uri.Login.manualLogin() | }

{/form}

It should show

  • method
  • class
  • id

//cc @FroMage

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 2, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 2, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 2, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 2, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 3, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 4, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 10, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 10, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 10, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 10, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Feb 10, 2023
Fixes redhat-developer#784

Signed-off-by: azerr <azerr@redhat.com>
@datho7561 datho7561 added this to the 0.14.0 milestone Feb 10, 2023
@datho7561 datho7561 moved this to 👀 In review in IDE Cloudaptors Feb 10, 2023
@datho7561 datho7561 added the enhancement New feature or request label Feb 10, 2023
datho7561 pushed a commit that referenced this issue Feb 10, 2023
Fixes #784

Signed-off-by: azerr <azerr@redhat.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants