Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support ? in parameter let section #906

Closed
angelozerr opened this issue Jul 21, 2023 · 0 comments · Fixed by #907
Closed

Fix support ? in parameter let section #906

angelozerr opened this issue Jul 21, 2023 · 0 comments · Fixed by #907
Assignees
@angelozerr
Labels
bug Something isn't working qute
Milestone
0.16.0

Comments

@angelozerr
Copy link
Contributor

The PR #905 loose the capability to use a parameter let section assigned with ? (declared in user tag) in a Qute template.

If you open https://github.com/ia3andy/quarkus-blast/blob/aa969f34616ec63be0268fee20a40097d2ec1ba4/src/main/resources/templates/layout/page.html#L7 you will have an error which says that name doesn't exist.
@angelozerr angelozerr added bug Something isn't working qute labels Jul 21, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
4654401 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 21, 2023
Merged
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
d21bbbb 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the 0.16.0 milestone Jul 21, 2023
@angelozerr angelozerr self-assigned this Jul 21, 2023
@angelozerr angelozerr moved this to 👀 In review in IDE Cloudaptors Jul 21, 2023
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
16d6c53 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
9fe2885 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jul 21, 2023
@angelozerr
Show section parameter default value as inlay hint settings
2efc268 
See redhat-developer/quarkus-ls#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jul 21, 2023
@angelozerr
Show section parameter default value as inlay hint settings
12d31db 
See redhat-developer/quarkus-ls#906

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 21, 2023
Merged
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jul 21, 2023
@angelozerr
Show section parameter default value as inlay hint settings
971836c 
See redhat-developer/quarkus-ls#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
723200f 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
9449a07 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
6d677ce 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jul 21, 2023
@angelozerr
Fix support ? in parameter let section
1e09a98 
Fixes redhat-developer#906

Signed-off-by: azerr <azerr@redhat.com>
datho7561 pushed a commit that referenced this issue Jul 21, 2023
@angelozerr @datho7561
Fix support ? in parameter let section
483258f 
Fixes #906

Signed-off-by: azerr <azerr@redhat.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Jul 21, 2023
datho7561 pushed a commit to redhat-developer/vscode-quarkus that referenced this issue Jul 21, 2023
@angelozerr @datho7561
Show section parameter default value as inlay hint settings
93bae76 
See redhat-developer/quarkus-ls#906

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working qute
Projects
IDE Cloudaptors
Archived in project
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Fix support ? in parameter let section angelozerr/quarkus-ls
1 participant
@angelozerr