-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for textDocument/InlayHint
#593
Conversation
This PR requires redhat-developer/vscode-quarkus#474 |
Here the result: It display Java type before the alias. It's just a POC and it doesn't use the real InlayHint of LSP4J but uses the structure like described in the spec. The inlay hint doesn't appear when the Java type is not resolved. So you must type something in the text editor to refresh the inlay hint. |
Nice :) Only 2 things immediately stand out.
|
d6f2dae
to
9c32c1d
Compare
@rgrunber here the new renderer: |
2ec4cbc
to
4709ec4
Compare
please don't use |
rename with |
546c257
to
31c57b5
Compare
7711fb0
to
0556249
Compare
Here a new demo with inlay hint: Now I support only section parameter (and method parameter type has been removed, we will see in an another PR the method parameter name support). This PR requires redhat-developer/vscode-quarkus#474 which provide settings to enable/disable inlay hints + provide inlay hint TypeScript by waiting for the release of vscode-languageclient which will provide this feature. |
Fixes redhat-developer#595 Signed-off-by: azerr <azerr@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, working as intended
Thanks @AlexXuChen for the review! |
Support for
textDocument/InlayHint
Fixes #595
Signed-off-by: azerr azerr@redhat.com