Added Qute CodeAction(s) for similar text suggestions for UnknownProperty
#693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Aug 4, 2022
| private Collection<String> collectAvailableValuesForPropertyPart(PropertyPart node, Template template, | ||
| String resolvedType) { | ||
| String projectUri = template.getProjectUri(); | ||
| return javaCache.resolveJavaType(resolvedType, projectUri).getNow(null).getFields().stream() |
There was a problem hiding this comment.
You dont need to use javaCache here. You can use directly baseResolvedType
There was a problem hiding this comment.
I suggest that you see property completion at
and you wiĺl see that it is not only fields of resolved type but too fields from extended type and method which have no parameters, value revolvers, etc
angelozerr
reviewed
Aug 4, 2022
....ls/src/main/java/com/redhat/qute/services/codeactions/QuteCodeActionForUnknownProperty.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Aug 4, 2022
....ls/src/main/java/com/redhat/qute/services/codeactions/QuteCodeActionForUnknownProperty.java
Show resolved
Hide resolved
AlexXuChen
force-pushed
the
issue602-code-action-suggestion-property
branch
from
64686f4
to
eb2918c
Compare
angelozerr
reviewed
Aug 4, 2022
| @@ -70,12 +76,14 @@ public void doCodeActions(CodeActionRequest request, List<CompletableFuture<Void | |||
| QuteTemplateGenerateMissingJavaMember resolver = request.getResolver(); | |||
| SharedSettings sharedSettings = request.getSharedSettings(); | |||
|
|
|||
| Part propertyPart = (Part) request.getCoveredNode(); | |||
| Part part = (Part) node; | |||
angelozerr
reviewed
Aug 4, 2022
....ls/src/main/java/com/redhat/qute/services/codeactions/QuteCodeActionForUnknownProperty.java
Show resolved
Hide resolved
angelozerr
reviewed
Aug 4, 2022
|
|
||
| List<String> javaFieldNames = baseResolvedType.getFields().stream().map(x -> x.getName()) | ||
| .collect(Collectors.toList()); | ||
| for (String fieldName : javaFieldNames) { |
There was a problem hiding this comment.
availableValues.addAll(javaFieldNames)
angelozerr
reviewed
Aug 4, 2022
| } | ||
| } | ||
|
|
||
| return availableValues; |
There was a problem hiding this comment.
It misses methods without parameters and value resolvers. See completion for property
Signed-off-by: Alexander Chen <alchen@redhat.com>
AlexXuChen
force-pushed
the
issue602-code-action-suggestion-property
branch
from
eb2918c
to
58992ec
Compare
angelozerr
reviewed
Aug 10, 2022
| @@ -183,4 +195,110 @@ private static void doCodeActionToCreateTemplateExtensionsClass(String missingPr | |||
| })); | |||
| } | |||
|
|
|||
| private static void doCodeActionToCreateProperty(Part propertyPart, ResolvedJavaTypeInfo baseResolvedType, | |||
There was a problem hiding this comment.
Why have you this static method which break the build in your PR? .
|
Replaced with #713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Qute CodeAction(s) for similar text suggestions for
UnknownProperty.Part of #602
Signed-off-by: Alexander Chen alchen@redhat.com