Definition for user tag parameter #790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
user-tag-param-def
branch
2 times, most recently
from
80deaa2
to
5e784f6
Compare
|
Here a demo:
|
angelozerr
force-pushed
the
user-tag-param-def
branch
from
5e784f6
to
11d73fd
Compare
Fixes redhat-developer#789 Signed-off-by: azerr <azerr@redhat.com>
|
What should happen if the user tag references the parameter many times? |
It go to the first definition. |
|
Hmm. I think it would be nice if we could show all the places it's used in the custom tag, but maybe that's more suited for "references". Also, if you have a type declaration of the parameter at the top of the custom tag template, it would be nice if "go to definition" went to that. |
Please see the new PR #794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition for user tag parameter
Fixes #789
Signed-off-by: azerr azerr@redhat.com