Ignore 'UndefinedObject' + 'UndefinedNamespace' problem code action should appear only if LSP client can support update configuration. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
approved these changes
Apr 20, 2023
|
This causes the tests to fail, since in the tests we expect the code action to appear, and it doesn't |
datho7561
requested changes
Apr 20, 2023
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
from
c3fa97b
to
3b3f879
Compare
Indeed I need to fix tests. |
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
2 times, most recently
from
3576bda
to
105d289
Compare
angelozerr
changed the title
|
@datho7561 tests should be fixed and I missed to do the same thing for UndefinedNamespace. |
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
from
105d289
to
0a70bf1
Compare
|
@datho7561 it seems that there is a problem with snapshot https://github.com/redhat-developer/quarkus-ls/actions/runs/4757288906/jobs/8453919530#step:7:443 |
Right, we need to point to lsp4mp |
datho7561
approved these changes
Apr 21, 2023
angelozerr
force-pushed
the
provide-undefinedobject-codeaction-ifclient-support
branch
from
0a70bf1
to
048ac03
Compare
should appear only if LSP client can support update configuration. Signed-off-by: azerr <azerr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore 'UndefinedObject' problem code action should appear only if LSP client can support update configuration.
In IJ Quarkus, it doesn't support the capability to update configuration on client side. In otherwise the
Ignore 'UndefinedObject' problemshould not appear:This PR checks that LSP client can support the command which update LSP client settings.