Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute now support optional end tags for sections #902

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

angelozerr
Copy link
Contributor

Qute now support optional end tags for sections

Fixes #879

@angelozerr
Copy link
Contributor Author

@datho7561
Copy link
Contributor

If you make the following change to the file (use {#let ...} in an {#if} block) :

diff --git a/src/main/resources/templates/GameController/game.html b/src/main/resources/templates/GameController/game.html
index bff6b4e..721483c 100644
--- a/src/main/resources/templates/GameController/game.html
+++ b/src/main/resources/templates/GameController/game.html
@@ -3,6 +3,7 @@
   {#if game}
     <div class="text-center game-container d-flex flex-grow-1 flex-column">
       <div class="flex-grow-1 justify-content-center d-flex flex-column order-lg-1">
+        {#let sandwich='salami'}
         {#include GameController/partials/grid.html}{/include}
         {#include GameController/partials/score.html}{/include}
       </div>

Then I get the following diagnostic:

Parser error: unterminated section [else] detected

@angelozerr
Copy link
Contributor Author

Good catch! Let me try fixing that.

@angelozerr
Copy link
Contributor Author

@datho7561 please retry it

Fixes redhat-developer#879

Signed-off-by: azerr <azerr@redhat.com>
@JessicaJHee
Copy link
Contributor

@angelozerr I noticed the same problem and can confirm now it is fixed!

@angelozerr
Copy link
Contributor Author

@angelozerr I noticed the same problem and can confirm now it is fixed!

Thanks for your feedback!

@angelozerr
Copy link
Contributor Author

Ok CI build is working again.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, Angelo!

@angelozerr angelozerr merged commit 51ab4af into redhat-developer:master Jul 20, 2023
@angelozerr
Copy link
Contributor Author

Thanks @datho7561 @JessicaJHee for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute now support optional end tags for sections
3 participants