fix: allow spaces inside section branch. #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
whitespaces_in_section
branch
from
2e17766 to
36497f7
Compare
fbricon
reviewed
Jul 8, 2024
...s/com.redhat.qute.ls/src/test/java/com/redhat/qute/services/inlayhint/QuteInlayHintTest.java
Show resolved
Hide resolved
fbricon
reviewed
Jul 8, 2024
.../java/com/redhat/qute/services/completions/QuteCompletionInExpressionWithLetSectionTest.java
Show resolved
Hide resolved
fbricon
reviewed
Jul 8, 2024
Comment on lines
98
to
100
| //if (!stream.eos() && (stream.peekChar() == ' ' || stream.peekChar() == '=')) { | ||
| // state = ScannerState.WithinParameters; | ||
| //} else { |
|
ok to merge once the nitpicks are addressed |
Signed-off-by: azerr <azerr@redhat.com>
angelozerr
force-pushed
the
whitespaces_in_section
branch
from
36497f7 to
f490e9b
Compare
|
thanks @angelozerr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the capability to add any spaces between parameters of section
Ex :
will not report error in
{foo}because foo can be computed correctly even with extra spaces.