This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Adapt to new plugin notation #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi The che server [build 1408] failed.If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel. |
ibuziuk
changed the title
ibuziuk
approved these changes
May 13, 2019
|
@amisevsk @davidfestal could you please review? |
|
@amisevsk it looks like you have already done all the required changes and this PR can be safely closed, right? |
|
probably we can just import the doc changes in |
amisevsk
approved these changes
May 13, 2019
|
@ibuziuk Yeah I didn't notice this PR and reproduced a few of the changes. The dev-guide changes are still great to merge though. |
|
Created #1407 |
|
Thank you @amisevsk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not merge until PR eclipse-che/che#13204 is in the version of upstream RhChe uses.
Note: this PR doesn't adapt resources prefetcher by @davidfestal
What issues does this PR fix or reference?
How have you tested this PR?