Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Updating to the latest 7.0.0-RC-2.0 upstream version #1445

Merged
merged 5 commits into from
Jul 2, 2019

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Jun 5, 2019

What does this PR do?

Updating to the latest 7.0.0-RC-2.0 upstream version

What issues does this PR fix or reference?

#1444

How have you tested this PR?

PR check against dev cluster

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1555] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 6, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1558] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 7, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1561] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 10, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1565] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 11, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1568] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 12, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1570] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1570/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1570/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 12, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1572] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 13, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1576] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 14, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1577] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1577/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1577/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 14, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1579] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1579/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1579/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 14, 2019

@Katka92 @ScrewTSW looks like there were changes in upstream and RC2 update started to fail:

[INFO] Compiling 6 source files to /root/payload/functional-tests/target/test-classes
warning: Supported source version 'RELEASE_6' from annotation processor 'org.jvnet.hudson.annotation_indexer.AnnotationProcessorImpl' less than -source '1.8'
/root/payload/functional-tests/src/test/java/com/redhat/che/functional/tests/Che7DialogAbout.java:124: error: cannot find symbol
newWorkspace.clickOnAllStacksTab();
^
symbol: method clickOnAllStacksTab()
location: variable newWorkspace of type NewWorkspace
/root/payload/functional-tests/src/test/java/com/redhat/che/functional/tests/Che7DialogAbout.java:131: error: cannot find symbol
newWorkspace.setMachineRAM("dev-machine", machineRam);
^
symbol: method setMachineRAM(String,Double)
location: variable newWorkspace of type NewWorkspace
2 errors
1 warning

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 14, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1580] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1580/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1580/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1582] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1582/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1582/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 14, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1583] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 17, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1592] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@amisevsk
Copy link
Collaborator

@ibuziuk Note that before merging this PR we should double check upstream dashboard changes; we're currently overriding upstream functionality in an unintended way -- I'll take a closer look.

@amisevsk
Copy link
Collaborator

I've added a commit to adapt upstream devfile changes to this PR, but haven't had a chance to test it much. The relevant upstream PR: eclipse-che/che#13469

@ibuziuk ibuziuk requested review from Katka92, amisevsk, rhopp and davidfestal and removed request for amisevsk June 21, 2019 11:30
@ibuziuk ibuziuk changed the title [DO NOT MERGE] Updating to the latest 7.0.0-RC-2.0 upstream version Updating to the latest 7.0.0-RC-2.0 upstream version Jun 21, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 21, 2019

Prod is updated to CR 1.1 - so we are ready to promote CR 2 to prod-preview

ibuziuk and others added 4 commits June 21, 2019 13:40
Update downstream overridden 'create workspace' page to match upstream
changes around devfile-based workspaces.

See commits b197f3d85f and 98062a88f7 from upstream for details.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@ibuziuk ibuziuk force-pushed the ibuziuk-patch-28 branch from 912e0a2 to 185aac7 Compare June 21, 2019 11:42
@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1620] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1620/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1620/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 21, 2019

@rhopp @Katka92 so, looks like che 7 tests are using dashboard UI:

Caused by: org.openqa.selenium.NoSuchElementException:
no such element: Unable to locate element: {"method":"xpath","selector":"//div[@data-stack-id='che7']"}

I believe the PR check tests need to be updated to use new devfile based apporach

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 21, 2019

[test]

1 similar comment
@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 21, 2019

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1621] failed.

Link URL
console https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1621/console
artifacts http://artifacts.ci.centos.org/devtools/rhche/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/1621/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

@centos-ci
Copy link
Collaborator

@ibuziuk The che server [build 1641] has been successfully deployed.

http://rhche-prcheck-1445.devtools-dev.ext.devshift.net

@Katka92
Copy link
Collaborator

Katka92 commented Jul 2, 2019

@ibuziuk Once this PR is merged, tests against production will fail due to the change in test. If the update on production will come e.g. next day after update on prod-preview, I think we can be OK with that. If you expect few days between updating prod-preview and prod, I would assume to add switch to the test.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 2, 2019

@Katka92 we will update prod only with GA version, so in the meantime, I would propose to merge this PR and start testing the latest version of upstream Che ASAP and adjust prod test suite to use stacks

@ibuziuk ibuziuk requested a review from ScrewTSW July 2, 2019 11:13
Copy link
Collaborator

@Katka92 Katka92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By merging that, Che 7 test against prod-preview production will be broken. Issue is known and @tdancs will work on that ASAP. +1 for merge.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 2, 2019

@Katka92 @ScrewTSW what is the test prod-preview issue?

@Katka92
Copy link
Collaborator

Katka92 commented Jul 2, 2019

@ibuziuk Sorry, my fault, I fixed my comment.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 2, 2019

@Katka92 ok, but is it a blocker for merging the PR. We could simply merge and fix the prod periodic tests separately?

@Katka92
Copy link
Collaborator

Katka92 commented Jul 2, 2019

Sure, that's why I wrote +1 for merging that PR. I hope that tomorrow we will have PR with the fix merged, so we will loose only 1 day of reports.

@ibuziuk ibuziuk merged commit 18e4ac4 into master Jul 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the ibuziuk-patch-28 branch July 2, 2019 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants