-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
Can one of the admins verify this patch? |
}, | ||
"features": { | ||
"disabled": ["workspaceSharing", "kubernetesNamespaceSelector"] | ||
}, | ||
"prefetch": { | ||
"cheCDN":"/api/cdn-support/paths" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not implemented yet in new dashboard. There is an issue eclipse-che/che#18728
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW should be even implement it?..
We can implement prefetch.resources
which is common enough and cheCDN should depends on the plan if it's going to be reused like on che-dev cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe any approach will work as long as pre-fetching will be possible to speed up the time for loading. Adding @davidfestal who initially developed the CDN prefetching mechanism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way it currently works is the following:
- The dashboard was pointing to the
/api/cdn-support/paths
endpoint to retrieve the list of resources to prefetch. - The
/api/cdn-support/paths
endpoint was implemented by anrh-che
extension to:- extract the CDN index annotation (containing a JSON list of CDN artifacts associated to the given version of Che-Theia) from the che-theia docker image configured as the default editor
- return it
[test] |
@sleshchenko RH-Che [build 3165] has been successfully deployed and tested.deployment: https://rhche-prcheck-2038.apps.che-dev.x6e0.p1.openshiftapps.com |
16f64cf
to
a6c29fe
Compare
rebasing the branch on top of #2043 (7.26.0-SNAPSHOT) and changing the base to |
[test] |
@sleshchenko PR check [build 3193] failed.Depending on failure reason, the artifacts or deployment may not be present. |
@sleshchenko @akurinnoy currently the new UD is failing to load on Hosted Che: could you please take a look? |
@ibuziuk it should work after eclipse-che/che-plugin-registry#820 is pulled |
[test] |
@sleshchenko PR check [build 3196] failed.Depending on failure reason, the artifacts or deployment may not be present. |
[test] |
@sleshchenko PR check [build 3198] failed.Depending on failure reason, the artifacts or deployment may not be present. |
[test] |
@sleshchenko the UD issue has been fixed \o/ verified it manually |
@sleshchenko PR check [build 3199] failed.Depending on failure reason, the artifacts or deployment may not be present. |
merging to |
What does this PR do?
It adapts RH Che to dashboard replacement that will be done in 7.26 eclipse-che/che#18549
What issues does this PR fix or reference?
How have you tested this PR?