Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Adapt to Dashboard replacement #2038

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

sleshchenko
Copy link
Contributor

What does this PR do?

It adapts RH Che to dashboard replacement that will be done in 7.26 eclipse-che/che#18549

What issues does this PR fix or reference?

How have you tested this PR?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

},
"features": {
"disabled": ["workspaceSharing", "kubernetesNamespaceSelector"]
},
"prefetch": {
"cheCDN":"/api/cdn-support/paths"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not implemented yet in new dashboard. There is an issue eclipse-che/che#18728

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW should be even implement it?..
We can implement prefetch.resources which is common enough and cheCDN should depends on the plan if it's going to be reused like on che-dev cluster.

Copy link
Member

@ibuziuk ibuziuk Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe any approach will work as long as pre-fetching will be possible to speed up the time for loading. Adding @davidfestal who initially developed the CDN prefetching mechanism

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way it currently works is the following:

  • The dashboard was pointing to the /api/cdn-support/paths endpoint to retrieve the list of resources to prefetch.
  • The /api/cdn-support/paths endpoint was implemented by an rh-che extension to:
    • extract the CDN index annotation (containing a JSON list of CDN artifacts associated to the given version of Che-Theia) from the che-theia docker image configured as the default editor
    • return it

@ibuziuk
Copy link
Member

ibuziuk commented Jan 14, 2021

[test]

@ibuziuk ibuziuk requested a review from davidfestal January 14, 2021 16:06
@centos-ci
Copy link
Collaborator

@ibuziuk ibuziuk changed the base branch from master to upstream-check-7.26.0-SNAPSHOT January 29, 2021 15:22
@ibuziuk
Copy link
Member

ibuziuk commented Jan 29, 2021

rebasing the branch on top of #2043 (7.26.0-SNAPSHOT) and changing the base to upstream-check-7.26.0-SNAPSHOT

@ibuziuk
Copy link
Member

ibuziuk commented Jan 29, 2021

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member

ibuziuk commented Jan 29, 2021

@sleshchenko @akurinnoy currently the new UD is failing to load on Hosted Che:

peek

could you please take a look?

@sleshchenko
Copy link
Contributor Author

@ibuziuk it should work after eclipse-che/che-plugin-registry#820 is pulled

@ibuziuk
Copy link
Member

ibuziuk commented Feb 1, 2021

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member

ibuziuk commented Feb 2, 2021

[test]

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member

ibuziuk commented Feb 2, 2021

[test]

@ibuziuk
Copy link
Member

ibuziuk commented Feb 2, 2021

@sleshchenko the UD issue has been fixed \o/ verified it manually
are you ok if we merge this PR to upstream-check-7.26.0-SNAPSHOT or do you plan some other modifications in the short run?

@centos-ci
Copy link
Collaborator

@ibuziuk
Copy link
Member

ibuziuk commented Feb 2, 2021

merging to upstream-check-7.26.0-SNAPSHOT

@ibuziuk ibuziuk changed the title WIP Adapt to Dashboard replacement Adapt to Dashboard replacement Feb 2, 2021
@ibuziuk ibuziuk marked this pull request as ready for review February 2, 2021 12:08
@ibuziuk ibuziuk merged commit a2d944b into upstream-check-7.26.0-SNAPSHOT Feb 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the dashboardNext branch February 2, 2021 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants