Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust startup, liveness and readiness probes settings #50

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix: adjust startup, liveness and readiness probes settings #50

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9844e8
Adjust startup, liveness and readiness probes settings
rm3l Dec 13, 2024
8159097
Update Chart version
rm3l Dec 13, 2024
0648ca6
Update charts/backstage/values.yaml
rm3l Dec 13, 2024
a226884
Add comment explaining why there is no 'initialDelaySeconds' on both …
rm3l Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.24.0
version: 2.24.1
2 changes: 1 addition & 1 deletion charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# RHDH Backstage Helm Chart for OpenShift (Community Version)

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/rhdh-chart&style=flat-square)](https://artifacthub.io/packages/search?repo=rhdh-chart)
![Version: 2.24.0](https://img.shields.io/badge/Version-2.24.0-informational?style=flat-square)
![Version: 2.24.1](https://img.shields.io/badge/Version-2.24.1-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub.
Expand Down
28 changes: 20 additions & 8 deletions charts/backstage/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,26 +81,38 @@ upstream:
cpu: 1000m
memory: 2.5Gi
ephemeral-storage: 5Gi
startupProbe:
# This gives enough time upon container startup before the liveness and readiness probes are triggered.
# Giving (120s = initialDelaySeconds + failureThreshold * periodSeconds) to account for the worst case scenario.
httpGet:
path: /.backstage/health/v1/liveness
port: backend
scheme: HTTP
initialDelaySeconds: 30
timeoutSeconds: 4
rm3l marked this conversation as resolved.
Show resolved Hide resolved
periodSeconds: 20
successThreshold: 1
failureThreshold: 3
readinessProbe:
failureThreshold: 3
httpGet:
path: /healthcheck
port: 7007
path: /.backstage/health/v1/readiness
port: backend
scheme: HTTP
initialDelaySeconds: 30
# initialDelaySeconds: 30
periodSeconds: 10
successThreshold: 2
timeoutSeconds: 2
timeoutSeconds: 4
rm3l marked this conversation as resolved.
Show resolved Hide resolved
livenessProbe:
failureThreshold: 3
httpGet:
path: /healthcheck
port: 7007
path: /.backstage/health/v1/liveness
port: backend
scheme: HTTP
initialDelaySeconds: 60
# initialDelaySeconds: 60
rm3l marked this conversation as resolved.
Show resolved Hide resolved
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 2
timeoutSeconds: 4
rm3l marked this conversation as resolved.
Show resolved Hide resolved
extraEnvVars:
- name: BACKEND_SECRET
valueFrom:
Expand Down
Loading