Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust startup, liveness and readiness probes settings (release-1.4) #51

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Dec 13, 2024

Description of the change

This is a manual cherry-pick of #50 to update the Chart version accordingly.
See #50 for more context.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

rm3l added 2 commits December 13, 2024 11:34
Startup probe settings seem to have been added in the upstream Backstage Chart
in [1], but the current settings do not allow the RHDH Chart for the
liveness probe to be triggered sufficiently enough for the app to be
considered live.
This adjust such settings by accounting for the worst case scenario
where the application might take a bit long to start.

This also aligns the probe endpoints with the upstream chart.

[1] backstage/charts#216
@openshift-ci openshift-ci bot requested review from davidfestal and kadel December 13, 2024 10:39
@rm3l
Copy link
Member Author

rm3l commented Dec 13, 2024

@openshift-ci openshift-ci bot requested review from gustavolira, nickboldt and PatAKnight and removed request for kadel and davidfestal December 13, 2024 10:39
@rm3l
Copy link
Member Author

rm3l commented Dec 13, 2024

https://github.com/redhat-developer/rhdh-chart/actions/runs/12314109406?pr=51

Old chart version: 2.24.0
New chart version: 2.23.1
Error: failed linting charts: failed processing charts
------------------------------------------------------------------------------------------------------------------------
 ✖︎ backstage => (version: "2.23.1", path: "charts/backstage") > chart version not ok. Needs a version bump! 
------------------------------------------------------------------------------------------------------------------------

From the CI logs, it looks like we can't have a patch version in the release-1.4 branch. We would need to cherry-pick #50 (including its Chart version bumped to 1.24.1) into release-1.4, then move main to 1.25.0?

/close

@openshift-ci openshift-ci bot closed this Dec 13, 2024
Copy link

openshift-ci bot commented Dec 13, 2024

@rm3l: Closed this PR.

In response to this:

Old chart version: 2.24.0
New chart version: 2.23.1
Error: failed linting charts: failed processing charts
------------------------------------------------------------------------------------------------------------------------
✖︎ backstage => (version: "2.23.1", path: "charts/backstage") > chart version not ok. Needs a version bump! 
------------------------------------------------------------------------------------------------------------------------

From the CI logs, it looks like we can't have a patch version in the release-1.4 branch. We would need to cherry-pick #50 (including its Chart version bump to 1.24.1) into release-1.4, then move main to 1.25.0.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l rm3l deleted the RHIDP-5106--1.4--fix-startup-probe-failures branch December 13, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant