Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @backstage/repo-tools and remove false positives in knip reports #435

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

04kash
Copy link
Member

@04kash 04kash commented Feb 20, 2025

Hey, I just made a Pull Request!

Updated @backstage/repo-tools to 0.13.0 which includes a fix to reduce the number of false positives reported by using a single workspace-based config instead of adding knip configs at plugin-level.

Fixes: https://issues.redhat.com/browse/RHIDP-5265

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Orchetsrator

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @04kash. Thanks for fixing these annoying false positives.

Please take a look why some unit tests are failing. Maybe because of an unwanted update? I saw an update of backend-plugin-api from 1.1.1 to 1.2.0. Is that related to two different backstage versions?

Everything else lgtm!

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Feb 28, 2025

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-bulk-import-backend
  • @red-hat-developer-hub/backstage-plugin-lightspeed-backend
  • @red-hat-developer-hub/backstage-plugin-catalog-backend-module-marketplace
  • @red-hat-developer-hub/backstage-plugin-marketplace-backend
  • @red-hat-developer-hub/backstage-plugin-marketplace-common
  • @red-hat-developer-hub/backstage-plugin-orchestrator

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-bulk-import-backend workspaces/bulk-import/plugins/bulk-import-backend none v5.3.0
@red-hat-developer-hub/backstage-plugin-lightspeed-backend workspaces/lightspeed/plugins/lightspeed-backend none v0.4.0
@red-hat-developer-hub/backstage-plugin-catalog-backend-module-marketplace workspaces/marketplace/plugins/catalog-backend-module-marketplace none v0.0.10
@red-hat-developer-hub/backstage-plugin-marketplace-backend workspaces/marketplace/plugins/marketplace-backend none v0.0.9
@red-hat-developer-hub/backstage-plugin-marketplace-common workspaces/marketplace/plugins/marketplace-common none v0.0.9
@red-hat-developer-hub/backstage-plugin-orchestrator workspaces/orchestrator/plugins/orchestrator none v2.6.1

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
@04kash
Copy link
Member Author

04kash commented Feb 28, 2025

@christoph-jerolimov I had to update update "@backstage/backend-test-utils" from ^1.2.1 to ^1.3.0 for bulk-import, marketplace and lightspeed to get the tests to pass. Would they need a changeset? Since this is just a devDependency change idts we need changesets but just wanted to make sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants