-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update @backstage/repo-tools and remove false positives in knip reports #435
base: main
Are you sure you want to change the base?
Conversation
bd93f69
to
f69837a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Orchetsrator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @04kash. Thanks for fixing these annoying false positives.
Please take a look why some unit tests are failing. Maybe because of an unwanted update? I saw an update of backend-plugin-api from 1.1.1 to 1.2.0. Is that related to two different backstage versions?
Everything else lgtm!
6e49673
to
b93143f
Compare
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
94593b0
to
1684bde
Compare
|
@christoph-jerolimov I had to update update "@backstage/backend-test-utils" from ^1.2.1 to ^1.3.0 for bulk-import, marketplace and lightspeed to get the tests to pass. Would they need a changeset? Since this is just a devDependency change idts we need changesets but just wanted to make sure |
Hey, I just made a Pull Request!
Updated
@backstage/repo-tools
to 0.13.0 which includes a fix to reduce the number of false positives reported by using a single workspace-based config instead of adding knip configs at plugin-level.Fixes: https://issues.redhat.com/browse/RHIDP-5265
✔️ Checklist