feat(theme): new plugins to test common components and issues #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-jerolimov
requested review from
ciiay and
debsmita1
as code owners
christoph-jerolimov
force-pushed
the
theme-tests
branch
5 times, most recently
from
b5b0413
to
ff0ad9a
Compare
christoph-jerolimov
changed the title
christoph-jerolimov
force-pushed
the
theme-tests
branch
2 times, most recently
from
9c20152
to
0e60c6c
Compare
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
theme-tests
branch
from
0e60c6c
to
4687a64
Compare
|
Hi @christoph-jerolimov , are these plugins supposed to be tested on the backstage-showcase, aka RHDH to identify the UI differences on same components? |
Exactly. I'm busy these days, but I will test it and provide additional information on how to test it on RHDH at the end of this week. If you think it looks good, we can merge it anyway, but there's no pressure. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Creates three new "test plugins"
@red-hat-developer-hub/backstage-plugin-bsc-testthat adds a page with common Backstage components@red-hat-developer-hub/backstage-plugin-mui4-testthat adds a page with MUI v4 components@red-hat-developer-hub/backstage-plugin-mui5-testthat adds a page with MUI v5 componentsWith dynamic plugin support, they should allow us to test common issues.
The first version contains "test components" for:
Backstage Components Tests
MUI v4 / Material UI Test Page
MUI v5 Test Page
✔️ Checklist