fix(orchestrator): execute should allow no inputs #73
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gciavarrini
reviewed
Nov 25, 2024
| @@ -163,12 +163,11 @@ export class V2 { | |||
| workflowId: string, | |||
| businessKey: string | undefined, | |||
| ): Promise<ExecuteWorkflowResponseDTO> { | |||
| if (Object.keys(executeWorkflowRequestDTO?.inputData).length === 0) { | |||
| if (!executeWorkflowRequestDTO?.inputData) { | |||
There was a problem hiding this comment.
inputData is a required field in the spec. You need to fix the spec too
There was a problem hiding this comment.
if it's required why are we checking this?
There was a problem hiding this comment.
maybe we don't need this check?
There was a problem hiding this comment.
Revisisted it
I think the inputData should be optional, so I changed the spec for it to be optional
Actually useful, a workflow without parameters can be run without need to pass a body:
curl -X POST http://localhost:7007/api/orchestrator/v2/workflows/hello_world/execute
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Changed Packages
|
Changed Packages
|
Changed Packages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is that execute fails also if field inputData is passed but is empty.
This causes workflows without required inputs to fail.
Changing inputData field to be optional
This resolves the bug in a cleaner way than janus-idp/backstage-plugins#2550
Resolves FLPATH-1880